Repository navigation
Perf(test): shrink synthetic volumes in image loading and dataset tests - #9034
Conversation
…ts (Project-MONAI#9034) Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
22d45da to
6cb74f7
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Project-MONAI/MONAI/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe test suite now uses smaller image volumes in dataset and image-loading tests. Expected shapes and metadata fixtures were updated. The mapping-file test uses 16×16×16 volumes. Existing test coverage remains in place. Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to The test fixtures use smaller volumes without an identified mismatch in the affected test operations. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Description
Shrinks the synthetic volumes these six test files generate, so each test still exercises the same code paths in a fraction of the runtime. Pure test-fixture change: no production code touched, no test logic altered:
tests/transforms/test_load_image.py,tests/transforms/test_load_imaged.py: 128³ volumes → 32³; multi-image cases 3×128³ → 3×32³; the 384×128³ channel-dim case scales to 96×32³.tests/data/test_arraydataset.py,test_cachedataset.py,test_dataset.py: 128³ → 32³; the Spacing case 64×64×33 → 16×16×9.tests/data/test_mapping_file.py: 128³ → 16³.The 128³ sizes were an unexamined default; nothing depends on the magnitude, only that shapes round-trip through
.nii.gzI/O. Expected shapes were updated in lockstep, so the assertions still verify the same behaviour.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.