Skip to content

fix(events): generalize event landing page routes from data - #701

Open
senutpal wants to merge 1 commit into
Project-HAMi:masterfrom
senutpal:fix/generalize-event-landing-routes
Open

fix(events): generalize event landing page routes from data#701
senutpal wants to merge 1 commit into
Project-HAMi:masterfrom
senutpal:fix/generalize-event-landing-routes

Conversation

@senutpal

@senutpal senutpal commented Aug 2, 2026

Copy link
Copy Markdown

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Generalizes event landing page routes by dynamically registering /landing/${event.slug} routes in plugin-events using Docusaurus actions.addRoute with props: { slug: event.slug }. Passes slug directly to <EventLanding /> without relying on URL path parsing or magic. Also adds getPathsToWatch so additions to src/data/events.js trigger hot-reloading during development, and removes redundant static wrapper files under src/pages/landing/.

Which issue(s) this PR fixes: Fixes #653

Checklist:

  • npm run lint and npm run format:check pass
  • npm run build succeeds for both en and zh
  • Chinese translation updated if English docs changed (or noted why not) (N/A: no doc changes)
  • Commits are signed off (git commit -s)

Summary by CodeRabbit

  • New Features

    • Added dynamic landing pages for configured events at /landing/:slug.
    • Landing page titles and descriptions now display consistently across supported languages.
  • Bug Fixes

    • Removed outdated KubeCon Japan and KCD Vietnam landing pages.

@hami-robot hami-robot Bot added the kind/cleanup Refactoring, config, or tidy-up with no behavior change label Aug 2, 2026
@hami-robot

hami-robot Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: senutpal
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Aug 2, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 65c0fdf
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a6f83ed35ddd9000823d498
😎 Deploy Preview https://deploy-preview-701--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot

hami-robot Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Welcome @senutpal! It looks like this is your first PR to Project-HAMi/website 🎉

@hami-robot hami-robot Bot added the size/S label Aug 2, 2026
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@senutpal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d0924214-74db-4040-841c-b7705fdf19e3

📥 Commits

Reviewing files that changed from the base of the PR and between b235aa5 and 65c0fdf.

📒 Files selected for processing (4)
  • src/components/EventLanding.js
  • src/pages/landing/kcd-vietnam.js
  • src/pages/landing/kubecon-japan.js
  • src/plugins/events/index.js
📝 Walkthrough

Walkthrough

The events plugin now derives landing routes from event data and watches that data module. EventLanding uses pick for localized metadata. The dedicated Vietnam and Japan landing modules were removed.

Changes

Event landing routing

Layer / File(s) Summary
Localized event rendering
src/components/EventLanding.js
EventLanding uses pick to pass localized event titles and descriptions to Layout.
Dynamic landing route registration
src/plugins/events/index.js, src/pages/landing/kcd-vietnam.js, src/pages/landing/kubecon-japan.js
The events plugin imports landing-event data, watches the data module, and registers exact /landing/:slug routes. The dedicated Vietnam and Japan page modules were removed.

Estimated code review effort: 3 (Moderate) | ~15 minutes

Possibly related PRs

Suggested reviewers: bhuvan-somisetty

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: generating event landing routes from event data.
Linked Issues check ✅ Passed The PR registers landing routes from src/data/events.js and removes per-event wrapper files, satisfying the DRY routing objective in [#653].
Out of Scope Changes check ✅ Passed All changes support data-driven event landing routes, including shared rendering and removal of redundant static page modules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Utpal Sen <contactutpalsen@gmail.com>
@senutpal
senutpal force-pushed the fix/generalize-event-landing-routes branch from b235aa5 to 65c0fdf Compare August 2, 2026 17:52
@mesutoezdil

Copy link
Copy Markdown
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui dco-signoff: yes kind/cleanup Refactoring, config, or tidy-up with no behavior change lgtm size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalize the landing page slug

2 participants