fix(events): generalize event landing page routes from data - #701
fix(events): generalize event landing page routes from data#701senutpal wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: senutpal The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @senutpal! It looks like this is your first PR to Project-HAMi/website 🎉 |
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe events plugin now derives landing routes from event data and watches that data module. EventLanding uses ChangesEvent landing routing
Estimated code review effort: 3 (Moderate) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Utpal Sen <contactutpalsen@gmail.com>
b235aa5 to
65c0fdf
Compare
|
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Generalizes event landing page routes by dynamically registering
/landing/${event.slug}routes inplugin-eventsusing Docusaurusactions.addRoutewithprops: { slug: event.slug }. Passesslugdirectly to<EventLanding />without relying on URL path parsing or magic. Also addsgetPathsToWatchso additions tosrc/data/events.jstrigger hot-reloading during development, and removes redundant static wrapper files undersrc/pages/landing/.Which issue(s) this PR fixes: Fixes #653
Checklist:
npm run lintandnpm run format:checkpassnpm run buildsucceeds for bothenandzhgit commit -s)Summary by CodeRabbit
New Features
/landing/:slug.Bug Fixes