fix: consolidate duplicated date formatting into src/utils/date.js by bhuvan-somisetty · Pull Request #698 · Project-HAMi/website

bhuvan-somisetty · 2026-08-02T03:19:19Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Date/time formatting was implemented independently in five places instead of going through the shared src/utils/date.js utility that already exists for it. src/utils/date.js's own formatDate/formatDateRange exports were unused dead code, while EventLanding.js, case-studies.js, and BlogPostItem/Header/index.js each carried their own copy with slightly different locale mapping and format options.

This wasn't just cosmetic duplication — it already caused a shipped bug (#659, dates showing a day early west of UTC). The fix for that bug had to be hand-applied to three separate files (commit a6b7c643) because there was no single place to patch, and EventLanding.js's independent copy wasn't touched by that fix at all (it happened to already have timeZone: "UTC" by luck).

This PR:

Extends src/utils/date.js with formatShortDate/formatNumericDate presets, and gives formatDateRange the formatRange feature-detection fallback that only EventLanding.js previously had (so it no longer throws in environments without Intl.DateTimeFormat.prototype.formatRange).
Replaces the local formatDate/formatDateRange copies in EventLanding.js, case-studies.js, and BlogPostItem/Header/index.js with imports from the shared utility, preserving each page's existing format granularity (long/short/numeric month) as an explicit named preset instead of an accidental divergence.
Adds unit tests for src/utils/date.js using Node's built-in test runner (node:test), including a regression test for the Blog post and case study dates are one day early west of UTC #659 UTC date-boundary bug across both en and zh locales, and a test for the formatRange fallback path. No new dependency: src/utils/package.json scopes "type": "module" to that directory so the ESM source runs directly under node --test without affecting the rest of the (CommonJS) repo or the webpack build.
Adds npm run test (wired into check:all and CI) and documents in CONTRIBUTING.md that date/time formatting should go through src/utils/date.js.

src/theme/BlogArchivePage/index.js already uses Docusaurus's useDateTimeFormat hook correctly and is left as-is — it's a different mechanism, not a duplicate of src/utils/date.js.

Verified in the built HTML for all three presets: case studies (short, en) Jul 2, 2026, case studies (short, zh) 2026年7月2日, blog post header (numeric, en) 3/19/2026, event landing page (long range, en) July 28 – 30, 2026.

Which issue(s) this PR fixes:

Fixes #697

Checklist:

npm run lint and npm run format:check pass
npm run build succeeds for both en and zh
Chinese translation updated if English docs changed (or noted why not) - N/A, no doc content changed
Commits are signed off (git commit -s)

Summary by CodeRabbit

Improvements
- Standardized date displays across event pages, case studies, and blog posts.
- Improved date formatting for English and Chinese locales.
- Added reliable date-range display for browsers that lack native range-formatting support.
Documentation
- Updated contributor guidance and CI checklist to include unit tests.
Testing
- Expanded automated coverage for date formatting and compatibility scenarios.

hami-robot · 2026-08-02T03:19:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhuvan-somisetty
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-08-02T03:19:25Z

✅ Deploy Preview for project-hami ready!

Name	Link
🔨 Latest commit	`cd7cdf9`
🔍 Latest deploy log	https://app.netlify.com/projects/project-hami/deploys/6a709e9703f7bc0008a832f3
😎 Deploy Preview	https://deploy-preview-698--project-hami.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Date/time formatting was reimplemented independently in EventLanding.js, case-studies.js, and BlogPostItem/Header/index.js instead of using the shared src/utils/date.js utility, which itself had unused exports. This already caused a shipped bug (Project-HAMi#659) that had to be hand-patched across three separate files because there was no single source of truth. - Extend src/utils/date.js with formatShortDate/formatNumericDate presets and give formatDateRange the formatRange feature-detection fallback that only EventLanding.js previously had. - Replace the local formatDate/formatDateRange copies in EventLanding.js, case-studies.js, and BlogPostItem/Header/index.js with imports from the shared utility, preserving each page's existing format granularity as an explicit named preset. - Add unit tests for src/utils/date.js using Node's built-in test runner, including a regression test for the Project-HAMi#659 UTC date-boundary bug. - Wire npm run test into check:all and CI, and document the "date formatting goes through src/utils/date.js" convention in CONTRIBUTING.md. Fixes Project-HAMi#697 Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>

coderabbitai · 2026-08-02T03:20:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ddd01750-fd7e-406d-a809-7e99efc45c2a

📥 Commits

Reviewing files that changed from the base of the PR and between 3ec2dc3 and cd7cdf9.

📒 Files selected for processing (9)

.github/workflows/docs-health.yml
CONTRIBUTING.md
package.json
src/components/EventLanding.js
src/pages/case-studies.js
src/theme/BlogPostItem/Header/index.js
src/utils/date.js
src/utils/date.test.js
src/utils/package.json

📝 Walkthrough

Walkthrough

The change centralizes date formatting in shared UTC-based utilities, updates event, case-study, and blog rendering, adds utility tests, and expands Node test discovery across scripts, CI, and contributor documentation.

Changes

Date formatting and validation

Layer / File(s)	Summary
Shared date utilities and regression tests `src/utils/date.js`, `src/utils/date.test.js`, `src/utils/package.json`	Shared long, short, numeric, and range formatters use UTC. Range formatting includes a `formatRange` fallback. Tests cover locales and fallback behavior.
Date rendering integrations `src/components/EventLanding.js`, `src/pages/case-studies.js`, `src/theme/BlogPostItem/Header/index.js`	Components use shared date utilities instead of local formatting implementations.
Test workflow and contributor checks `package.json`, `.github/workflows/docs-health.yml`, `CONTRIBUTING.md`	The test script uses Node test discovery. Aggregate checks, CI, and contributor guidance now include unit tests.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Project-HAMi/website#632: Both changes modify src/utils/date.js.
Project-HAMi/website#642: Both changes modify src/components/EventLanding.js.

Suggested labels: kind/bug

Suggested reviewers: rootsongjc, archlitchi

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes consolidating duplicated date formatting into the shared utility.
Linked Issues check	✅ Passed	The changes implement the shared date utility, replace duplicated logic, preserve format variants, add locale and fallback tests, and document the convention for issue `#697`.
Out of Scope Changes check	✅ Passed	The CI, test script, module configuration, and documentation changes directly support the linked issue objectives.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

bhuvan-somisetty · 2026-08-02T03:30:27Z

@rootsongjc @mesutoezdil could one of you take a look when you get a chance? All checks are green, just needs a review/lgtm. Thanks!

fishman · 2026-08-02T15:42:42Z

Looks like an oversight. I thought I replaced all Eventlanding occurances after creating the date.js helper. But it's nice to see it used for BlogPosts as well.

/lgtm

bhuvan-somisetty · 2026-08-02T15:47:14Z

Thanks for taking a look! Yeah, EventLanding had its own copy with the UTC fix baked in already, so it just needed to be swapped over to the shared util like the rest. Glad it's cleaner now for BlogPosts too.

Resolve conflicts in .github/workflows/docs-health.yml and package.json by consolidating the two independently-added test scripts (mine for src/utils/date.test.js, upstream's for the markdown edge function tests) into a single npm run test that node --test discovers via its default globbing.

hami-robot · 2026-08-03T13:58:48Z

New changes are detected. LGTM label has been removed.

bhuvan-somisetty · 2026-08-03T13:59:13Z

Conflicts resolved, merged in the latest master and everything's green now. @rootsongjc thanks again for merging my last one, appreciate the guidance - would love your eyes on this when you get a chance!

hami-robot Bot added the dco-signoff: no label Aug 2, 2026

hami-robot Bot requested review from archlitchi and rootsongjc August 2, 2026 03:19

hami-robot Bot added the size/L label Aug 2, 2026

github-actions Bot added area/ci-infra area/ui labels Aug 2, 2026

bhuvan-somisetty force-pushed the fix/consolidate-date-formatting branch from 77a4489 to 2116467 Compare August 2, 2026 03:20

hami-robot Bot added dco-signoff: yes and removed dco-signoff: no labels Aug 2, 2026

hami-robot Bot assigned fishman Aug 2, 2026

hami-robot Bot added the lgtm label Aug 2, 2026

hami-robot Bot removed the lgtm label Aug 3, 2026

coderabbitai Bot added the kind/bug Something isn't working label Aug 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: consolidate duplicated date formatting into src/utils/date.js - #698

fix: consolidate duplicated date formatting into src/utils/date.js#698
bhuvan-somisetty wants to merge 2 commits into
Project-HAMi:masterfrom
bhuvan-somisetty:fix/consolidate-date-formatting

bhuvan-somisetty commented Aug 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

hami-robot Bot commented Aug 2, 2026

Uh oh!

netlify Bot commented Aug 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 2, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

bhuvan-somisetty commented Aug 2, 2026

Uh oh!

fishman commented Aug 2, 2026

Uh oh!

bhuvan-somisetty commented Aug 2, 2026

Uh oh!

hami-robot Bot commented Aug 3, 2026

Uh oh!

bhuvan-somisetty commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bhuvan-somisetty commented Aug 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

hami-robot Bot commented Aug 2, 2026

Uh oh!

netlify Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for project-hami ready!

Uh oh!

coderabbitai Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

bhuvan-somisetty commented Aug 2, 2026

Uh oh!

fishman commented Aug 2, 2026

Uh oh!

bhuvan-somisetty commented Aug 2, 2026

Uh oh!

hami-robot Bot commented Aug 3, 2026

Uh oh!

bhuvan-somisetty commented Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bhuvan-somisetty commented Aug 2, 2026 •

edited by coderabbitai Bot

Loading

netlify Bot commented Aug 2, 2026 •

edited

Loading

coderabbitai Bot commented Aug 2, 2026 •

edited

Loading