ci(helm): add chart release workflows - #113
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughAdds Helm chart documentation and schema generation, pull-request validation, push/manual OCI releases to GHCR, and expanded cross-platform repository ignore rules. ChangesHelm chart automation
Repository maintenance
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant ChartVersion
participant HelmChartReleaser
participant GHCR
GitHubActions->>ChartVersion: Read current and previous chart versions
ChartVersion->>GitHubActions: Return version_changed
GitHubActions->>HelmChartReleaser: Package chart and update gh-pages
HelmChartReleaser->>GHCR: Check version and push OCI chart
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Welcome @spencercjh! It looks like this is your first PR to Project-HAMi/ascend-device-plugin 🎉 |
bd64f4b to
9e01f3c
Compare
|
/assign archlitchi |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-helm-release.yaml:
- Around line 11-20: Add a workflow-level permissions default near the existing
env/concurrency configuration in the Helm release workflow, setting the GitHub
Actions token to read-only (contents: read). Keep the explicit elevated
permissions in release jobs unchanged.
In @.github/workflows/helm-lint.yaml:
- Around line 41-42: Update the actions/checkout step named “Checkout” in the
Helm lint workflow to set persist-credentials to false before make
verify-helm-chart runs, while leaving the existing checkout behavior and local
git diff functionality unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bec4860b-270d-4dd1-b877-1618e733c8ca
📒 Files selected for processing (8)
.github/workflows/build-helm-release.yaml.github/workflows/helm-lint.yaml.gitignoreMakefilecharts/ascend-device-plugin/README.mdcharts/ascend-device-plugin/README.md.gotmplcharts/ascend-device-plugin/values.schema.jsoncharts/ascend-device-plugin/values.yaml
|
It's almost copied from https://github.com/dynamia-ai/ppu-vgpu-device-plugin |
|
/assign DSFans2014 |
e7a3bfb to
e97da30
Compare
124012c to
66320b3
Compare
Signed-off-by: Spencer Cai <jiahao.cai@dynamia.ai>
Signed-off-by: Spencer Cai <jiahao.cai@dynamia.ai>
Signed-off-by: Spencer Cai <jiahao.cai@dynamia.ai>
Signed-off-by: Spencer Cai <jiahao.cai@dynamia.ai>
Signed-off-by: spencercjh <spencercjh@gmail.com>
Signed-off-by: spencercjh <spencercjh@gmail.com>
66320b3 to
62c9904
Compare
Signed-off-by: spencercjh <spencercjh@gmail.com>
Signed-off-by: spencercjh <spencercjh@gmail.com>
Signed-off-by: spencercjh <spencercjh@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, spencercjh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Most of this Pull Request was generated or revised with the assistance of AI tools(Codex with GPT-5.6 Sol High). I have reviewed the resulting content and take full responsibility for its accuracy, security, licensing compliance, and inclusion in this project.
Summary
Validation
make verify-helm-chartwith Helmv3.20.0actionlint .github/workflows/helm-lint.yaml .github/workflows/build-helm-release.yamlgit verify-commit HEADNotes
gh-pagesupdates.Summary by CodeRabbit
.gitignorecoverage for Linux, Go, macOS, IDE, and worktree artifacts.