Skip to content

fix(release): keep the release drafted until every platform has uploaded #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MotherSphere merged 1 commit into from
Sep 2, 2026
Merged

fix(release): keep the release drafted until every platform has uploaded #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,15 @@ jobs:
- name: Upload to the GitHub release
uses: softprops/action-gh-release@3d0d9888cb7fd7b750713d6e236d1fcb99157228 # v3.0.2
with:
# Without this the uploader PUBLISHES the release it is uploading to,
# because `draft` defaults to false and the action updates the release
# rather than only adding files. The first platform to finish
# therefore undoes the draft-hold, and the remaining platforms upload
# into a release that is already at /releases/latest. v0.3.1 went out
# that way: published with Linux and macOS while Windows was still
# compiling. `publish` is what makes it visible, once it has verified
# every asset is present.
draft: true
tag_name: ${{ needs.release-please.outputs.tag_name }}
files: |
${{ matrix.asset }}
Expand Down