Skip to content

fix(release): tell gh which repository, or the release publishes empty #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MotherSphere merged 1 commit into from
Sep 2, 2026
Merged

fix(release): tell gh which repository, or the release publishes empty #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,13 @@ jobs:
if: ${{ steps.release.outputs.release_created }}
env:
GH_TOKEN: ${{ github.token }}
run: gh release edit "${{ steps.release.outputs.tag_name }}" --draft=true
# `-R` is not optional: this job has no `actions/checkout`, so `gh` has
# no git remote to infer the repository from and dies with "fatal: not
# a git repository". That is exactly what happened on v0.3.0 — this step
# failed, `build` and `publish` were skipped, and the tag was published
# with no assets at all. Colony carries the same warning after paying
# for it with an empty v0.10.0.
run: gh release edit "${{ steps.release.outputs.tag_name }}" -R "${{ github.repository }}" --draft=true

build:
name: build ${{ matrix.asset }}
Expand Down Expand Up @@ -226,7 +232,7 @@ jobs:
steps:
- name: Verify the release carries everything
run: |
gh release view "$TAG" --json assets --jq '.assets[].name' | sort > /tmp/published
gh release view "$TAG" -R "$GITHUB_REPOSITORY" --json assets --jq '.assets[].name' | sort > /tmp/published
for a in $ASSETS; do
required="$a"
if [ "$SIGNED" = "true" ]; then
Expand All @@ -240,4 +246,5 @@ jobs:
echo "release verified"

- name: Make the release visible
run: gh release edit "$TAG" --draft=false
# Same reason as the draft step above: no checkout in this job either.
run: gh release edit "$TAG" -R "$GITHUB_REPOSITORY" --draft=false