Skip to content

Story #16561: update translation keys for traceability chain audit - #3982

Merged
bbenaissa merged 1 commit into
developfrom
story_16561_improve_traceability_chain_audit
Sep 18, 2026
Merged

Story #16561: update translation keys for traceability chain audit#3982
bbenaissa merged 1 commit into
developfrom
story_16561_improve_traceability_chain_audit

Conversation

@bbenaissa

@bbenaissa bbenaissa commented Sep 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Description des modifications

Type de changement

Indiquer le ou les types de changements

  • Build
  • PKI
  • Ansiblerie
  • Nouveau Code
  • Correction
  • Refactorisation de code
  • Autre

Documentation

Indiquer la documentation mise à jour

  • Quels sont les nouvelles documentations ?
  • Quels sont les modifications existantes ?
  • Quels sont les documentations ou sections de documentations supprimés ?

Tests

Indiquer comment le code à été testé (manuel, environnement, TU, etc)

  • manuel
  • environnement
  • TU

Migration

Indiquer si les modifications apportées impliquent une migration sur l'existant et comment la faire

Checklist

Sélectionner les éléments de la checklist

  • Mon code suit le style de code de ce projet.
  • J'ai commenté mon code, en particulier dans les classes et les méthodes difficile à comprendre.
  • J'ai fait les changements correspondant dans la documentation RAML.
  • J'ai fait les changements correspondant dans la documentation Métier.
  • J'ai fait les changements correspondant dans la documentation Technique.
  • J'ai rajouté les tests unitaires vérifiant mes fonctionnalités.
  • J'ai rajouté les tests de non régression vérifiant mes fonctionnalités.
  • Les tests unitaires nouveaux et existants passent avec succès localement.
  • Toutes les dépendances ont été mergées en priorité

Contributeur

Indiquer qui a développé cette fonctionnalité

  • VAS (Vitam Accessible en Service)
  • CEA (Commissariat à l'énergie atomique et aux énergies alternatives)

Summary by CodeRabbit

  • Localization
    • Added English and French labels for traceability chain audit reporting events.
    • Updated traceability chain finalization labels to use the audit finalization terminology in both languages.

@bbenaissa bbenaissa self-assigned this Sep 5, 2026
@bbenaissa bbenaissa added this to the IT 175 milestone Sep 5, 2026
@bbenaissa bbenaissa added enhancement New feature or request small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer VAS VAS contribution labels Sep 5, 2026
@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 67a217cd-8ec1-4f2c-a521-e9b49a9df2c9

📥 Commits

Reviewing files that changed from the base of the PR and between 420f14c and 2f4376c.

📒 Files selected for processing (2)
  • ui/ui-frontend/projects/vitamui-library/src/assets/shared-i18n/en.json
  • ui/ui-frontend/projects/vitamui-library/src/assets/shared-i18n/fr.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The shared English and French i18n resources add traceability chain audit reporting event keys and rename traceability chain finalization keys to audit finalization keys. Existing label values remain unchanged.

Changes

Traceability audit event labels

Layer / File(s) Summary
Add and rename audit event labels
ui/ui-frontend/projects/vitamui-library/src/assets/shared-i18n/en.json, ui/ui-frontend/projects/vitamui-library/src/assets/shared-i18n/fr.json		 The English and French resources add seven STP_TRACEABILITY_CHAIN_AUDIT_REPORTING keys. They rename seven TRACEABILITY_CHAIN_FINALIZATION keys to TRACEABILITY_CHAIN_AUDIT_FINALIZATION. Label values remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 2f437

This updates English and French labels for traceability audit reporting and audit finalization events. No concrete merge-blocking production or user-impact risk remains.

Suggested reviewers: marob

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only repeats the repository template. It does not provide the change details, change type, test information, migration impact, completed checklist items, or contributor information. Complete each required section. Describe the translation-key changes, select the change type, state the test method and results, explain whether migration is required, mark applicable checklist items, and identify the contributor.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the update to translation keys for traceability chain audit and includes the related story number.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch story_16561_improve_traceability_chain_audit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vitam-prg

vitam-prg commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Logo
Checkmarx One – Scan Summary & Details – 35fe56b0-6bb5-4303-abfd-9c1137084422

New Issues (12) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 HIGH CVE-2026-19534 Npm-undici-6.27.0
detailsRecommended version: 6.28.1
Description: undici's WebSocket client crashes the whole Node.js process during the opening handshake when a server responds with a subprotocol that the client ...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
2 HIGH CVE-2026-19534 Npm-undici-7.24.4
detailsRecommended version: 7.29.1
Description: undici's WebSocket client crashes the whole Node.js process during the opening handshake when a server responds with a subprotocol that the client ...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
3 HIGH CVE-2026-84961 Npm-undici-7.24.4
detailsRecommended version: 7.29.1
Description: undici's BalancedPool constructor passes its entire options object through an internal deep-clone that serializes and reparses the value as JSON. B...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
4 MEDIUM CVE-2026-18149 Npm-undici-7.24.4
detailsDescription: undici's retry handler can leave an already-exposed response body pending forever. When a server returns a successful response that declares a Cont...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
5 MEDIUM CVE-2026-84890 Npm-undici-7.24.4
detailsRecommended version: 7.29.1
Description: undici's decompress interceptor decompresses response bodies according to the untrusted Content-Encoding header. While the number of content-encodi...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
6 MEDIUM CVE-2026-84933 Npm-undici-7.24.4
detailsDescription: undici's cache interceptor does not handle the Set-Cookie response header anywhere in its cache path, so it neither refuses to store nor strips tha...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
7 MEDIUM CVE-2026-85014 Npm-undici-7.24.4
detailsRecommended version: 7.29.1
Description: undici's experimental WebSocketStream client crashes the whole Node.js process when a remote peer closes the TCP connection without a WebSocket clo...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
8 MEDIUM CVE-2026-85024 Npm-undici-6.27.0
detailsRecommended version: 6.28.1
Description: undici bundles a WebSocket client whose permessage-deflate size-limit cleanup removes all listeners from the internal zlib inflate stream, includin...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
9 LOW CVE-2026-18540 Npm-undici-7.24.4
detailsDescription: undici's retry interceptor can append the body of a ranged retry response to bytes already delivered from an earlier partial response while still p...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
10 LOW CVE-2026-18540 Npm-undici-6.27.0
detailsRecommended version: 6.28.1
Description: undici's retry interceptor can append the body of a ranged retry response to bytes already delivered from an earlier partial response while still p...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
11 LOW CVE-2026-84947 Npm-undici-7.24.4
detailsRecommended version: 7.29.1
Description: undici's dump interceptor reads and discards a response body up to a configurable maximum size. When a response declares a Content-Length that exce...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
12 LOW CVE-2026-85008 Npm-undici-7.24.4
detailsRecommended version: 7.29.1
Description: undici's cache interceptor documents that only safe HTTP methods are cached, but its logic to skip caching is built by subtracting the configured m...
Attack Vector: NETWORK
Attack Complexity: HIGH
Vulnerable Package
Fixed Issues (173) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
HIGH Reflected_XSS api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 181
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 85
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 175
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 248
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 217
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 216
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/IngestContractController.java: 265
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/UserController.java: 148
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/UserController.java: 148
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 217
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 343
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 207
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 207
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 343
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 207
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 382
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 380
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 437
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 410
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 342
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 438
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 438
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 410
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 343
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/GroupController.java: 301
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 380
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 410
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 380
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 382
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/UserController.java: 148
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 287
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 343
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 411
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 411
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/TransactionArchiveUnitController.java: 190
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 343
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 437
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/AccessContractController.java: 232
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/GroupController.java: 301
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 342
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 437
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 181
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 180
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 319
LOW Log_Forging api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 175
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 166
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 166
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/LogbookController.java: 147
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/ExternalParamProfileController.java: 183
LOW Log_Forging api/api-ingest/ingest/src/main/java/fr/gouv/vitamui/ingest/server/rest/IngestController.java: 125
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 237
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 166
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/ContextController.java: 163
LOW Log_Forging api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 117
LOW Log_Forging api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 117
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/FileFormatController.java: 132

More results are available on the CxOne platform

Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

@bbenaissa
bbenaissa merged commit 78c2b8f into develop Sep 18, 2026
22 of 23 checks passed
@bbenaissa
bbenaissa deleted the story_16561_improve_traceability_chain_audit branch September 18, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyahyaoui hyahyaoui hyahyaoui approved these changes
@hazco75 hazco75 hazco75 approved these changes

Assignees

@bbenaissa bbenaissa

Labels

enhancement New feature or request small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer VAS VAS contribution

Projects

None yet

Milestone

IT 175

Development

Successfully merging this pull request may close these issues.

4 participants

@bbenaissa @vitam-prg @hyahyaoui @hazco75