fix: add GitHub raw fallback & reduced timeout for Pastebin manifest - #549
Open
nandhanay wants to merge 1 commit into
Open
fix: add GitHub raw fallback & reduced timeout for Pastebin manifest#549nandhanay wants to merge 1 commit into
nandhanay wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #537
Hardcoded Pastebin dependency (
https://pastebin.com/raw/P4gfd98n) caused a ~14-second TCP connection timeout on startup for users in Turkey and regions where Pastebin is blocked.Changes
config/streaming_addon.txt.STREAMING_COLLECTION_ADDON_URLto GitHub raw URL and retainedPASTEBIN_STREAMING_ADDON_URLas secondary fallback.resolveAddonInstallUrlto use a 3.5s fast timeout and automatic fallback chain between GitHub raw and Pastebin.StreamAddonFallbackTest.