Skip to content

fix(stream): allow standard playback IDs for installed external Stremio addons (#139) #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himanth-reddy wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

fix(stream): allow standard playback IDs for installed external Stremio addons (#139) #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/kotlin/com/arflix/tv/data/repository/StreamRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,6 +1361,10 @@ class StreamRepository @Inject constructor(

private fun idMatchesAnyPrefix(id: String, prefixes: List<String>?): Boolean {
if (prefixes.isNullOrEmpty()) return true
val isStandardId = id.startsWith("tt", ignoreCase = true) ||
id.startsWith("tmdb:", ignoreCase = true) ||
id.startsWith("imdb:", ignoreCase = true)
if (isStandardId) return true
return prefixes.any { prefix ->
val normalizedPrefix = prefix.trim()
normalizedPrefix.isBlank() ||
Expand Down
13 changes: 13 additions & 0 deletions app/src/test/kotlin/com/arflix/tv/data/repository/StreamEpisodeRequestPlannerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,17 @@ class StreamEpisodeRequestPlannerTest {

assertEquals(false, shouldFallback)
}

@Test
fun `buildEpisodeIdCandidates produces valid candidates for tmdb and imdb ids`() {
val candidates = buildEpisodeIdCandidates(
seriesId = "tmdb:82928:1:1",
animeQuery = null,
tmdbEpisodeId = null,
preferNativeAnimeIds = false
)

assertEquals(listOf("tmdb:82928:1:1"), candidates.map { it.contentId })
assertEquals(listOf("imdb"), candidates.map { it.label })
}
}
Loading