chore(refactor): consolidate open refactoring PRs and apply code review fixes - #516
Open
Himanth-reddy wants to merge 15 commits into
Open
chore(refactor): consolidate open refactoring PRs and apply code review fixes#516Himanth-reddy wants to merge 15 commits into
Himanth-reddy wants to merge 15 commits into
Conversation
…s in repository layers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Exception Safety & Cancellation Propagation:
WatchHistoryRepository: RethrowsCancellationExceptionin primary save catch block.DetailsViewModel: PreservesCancellationExceptionpropagation in episode save/watch progress handlers.IptvRepository: Explicitly rethrowsCancellationExceptionin date formatting fallback logic.AuthRepository: Narrows broadInstant.parsecatch block toIllegalArgumentExceptionandDateTimeParseException.TvDeviceAuth & Response Polling:
TvDeviceAuthRepository: Uses an explicit outer label (outerUse@) on status polling responseuseblock so legacy 404 fallback exits the outer lambda directly without processing the 404 response.Data Models & Parsing:
IptvChannelStore: Safely parsesrequestHeaders_jsonas aJsonObjectretaining non-null string entries.IptvModels: Ensures safe collection immutability for channel request headers and snapshot models.AuthRepository: Validates Netlify account sync responses, treating malformed/missing responses as failed uploads.UI & Settings Validation:
SettingsViewModel: Narrows regex validation try-catch blocks toPatternSyntaxExceptionandIllegalArgumentException, returning boolean success status.SettingsScreen: Closes quality filter editor modal only when validation succeeds.Verification
./gradlew :app:compileSideloadDebugKotlin(BUILD SUCCESSFUL).