Repository navigation
Document the 0.001 minimum of lowerAsymptote - #40
Merged
Merged
Conversation
The check is fireSenseUtils::checkLinkParams(); the tests use the minimum instead of 0 and expect 0 to stop. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added a commit
that referenced
this pull request
Nov 14, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lower asymptote of 0 is no longer accepted: it is at least 0.001, because with 0 a fire that has not yet reached its minimum size could keep retrying for an unbounded number of generations.
Affects: a ledger row with
lowerAsymptote_spreadof 0 now stops; documentation only otherwise.Depends-on: PredictiveEcology/fireSenseUtils#230
Technical details
The check is
fireSenseUtils::checkLinkParams()(fireSenseUtils#230,spreadLowerAsymptoteMin= 1e-3); this module already calls it, so the behaviour comes from the package. ThefireSense_SpreadPowerLawoutput description names the minimum.Tests: the prediction tests use the minimum instead of 0, and a row with 0 stops with "never 0".
Full suite (module converted with
convertToPackage(buildDocuments = TRUE),test_local()): 303 pass, 0 fail, 0 skipped (302 before the change). Scratch library with fireSenseUtils#230 installed.Reuses:
fireSenseUtils::checkLinkParams(),spreadLowerAsymptoteMin; new: nothing.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6