Repository navigation
Use fireSenseUtils' shared escape-definition and random-effect helpers - #37
Merged
Merged
Conversation
Check the ledger's escape definition with checkEscapeDefinition() on the whole one-row-per-ELF table instead of the checkedEscapeDefinition() loop (the remaining function only builds the output table), take the run's definition from escapeDefinitionOf(sim), and use fireSenseUtils::fireSpreadSDTxt and yearSpreadSDTxt instead of the local copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added a commit
that referenced
this pull request
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fireSense_spreadPredict now uses the shared helpers in fireSenseUtils for the escape definition and the random-effect names, instead of its own copies, so there is one definition of each across fireSense.
Affects: nothing changes in results; an escape-definition mismatch now names the ELF.
Depends-on: PredictiveEcology/fireSenseUtils#222
Technical details
checkedEscapeDefinition()(fireSense_spreadPredict.R:618) looped over the non-NA ledger rows and calledcheckEscapeDefinition()once per row;fireSenseUtils::checkEscapeDefinition()now takes the whole table, so the loop is gone and the remainingledgerEscapeDefinition()only builds the output table. The run's definition comes fromfireSenseUtils::escapeDefinitionOf(sim)(which also does theparamCheckOtherMods()check onescapeSizeHaandfireCauses, replacing that part of the init loop).fireSpreadSDTxtandyearSpreadSDTxt(~:449) are now the exported fireSenseUtils constants. No behaviour change, so the addedELF Bexpectation intest-multiELF.Ralso passes on the base once fireSenseUtils#222 is installed. Suite with fireSenseUtils#222 and SpaDES.tools#156 installed: base and branch both 76 blocks, 251 expectations, 0 failures. The fireSenseUtils version floor inreqdPkgsis not raised until #222 is merged and bumped.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6