Repository navigation
skipUnusedFitPrep on by default - #136
Merged
Merged
Conversation
A run that does not fit no longer prepares the spread covariates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lx3DXgg187sAPQZwQT3Mf4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run that does not fit no longer prepares the spread fit data by default. There is no reason to build data that only a fit reads.
Affects:
skipUnusedFitPrepnow defaults to TRUE: a job withdoFit = FALSEthat does not validate, profile or hold out a fold skipsspreadFitPrepare.skipUnusedFitPrep = FALSErestores the old behaviour.Technical details
fireSense_spreadFit.R:90: default FALSE -> TRUE, description updated. Must merge together with PredictiveEcology/fireSense_dataPrepFit#111, which flips the same default: init stops when the two modules disagree on it.Tests:
test-metadataContract.Rpins the new default;test-skipUnusedFitPrep.Rchecks the default skips and FALSE prepares;test-initDecision.R(about the fit decision, not the prep) setsskipUnusedFitPrep = FALSEin itsinitOnly()helper so its expectations are unchanged. Full suite: 1292 pass, 0 fail (9 failed before the test updates, all expecting the old default).🤖 Generated with Claude Code
https://claude.ai/code/session_01Lx3DXgg187sAPQZwQT3Mf4