Skip to content

skipUnusedFitPrep on by default - #136

Merged
eliotmcintire merged 1 commit into
developmentfrom
feat/skipUnusedFitPrep-default-true
Nov 18, 2026
Merged

eliotmcintire merged 1 commit into
developmentfrom
feat/skipUnusedFitPrep-default-true

Conversation

@eliotmcintire

Copy link
Copy Markdown
Collaborator

A run that does not fit no longer prepares the spread fit data by default. There is no reason to build data that only a fit reads.

Affects: skipUnusedFitPrep now defaults to TRUE: a job with doFit = FALSE that does not validate, profile or hold out a fold skips spreadFitPrepare. skipUnusedFitPrep = FALSE restores the old behaviour.

Technical details

fireSense_spreadFit.R:90: default FALSE -> TRUE, description updated. Must merge together with PredictiveEcology/fireSense_dataPrepFit#111, which flips the same default: init stops when the two modules disagree on it.

Tests: test-metadataContract.R pins the new default; test-skipUnusedFitPrep.R checks the default skips and FALSE prepares; test-initDecision.R (about the fit decision, not the prep) sets skipUnusedFitPrep = FALSE in its initOnly() helper so its expectations are unchanged. Full suite: 1292 pass, 0 fail (9 failed before the test updates, all expecting the old default).

🤖 Generated with Claude Code

https://claude.ai/code/session_01Lx3DXgg187sAPQZwQT3Mf4

A run that does not fit no longer prepares the spread covariates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lx3DXgg187sAPQZwQT3Mf4
@eliotmcintire eliotmcintire added enhancement New feature or request backwards compatible Existing code and results keep working unchanged labels Nov 18, 2026
@eliotmcintire
eliotmcintire merged commit ee7adc1 into development Nov 18, 2026
9 checks passed
@eliotmcintire
eliotmcintire deleted the feat/skipUnusedFitPrep-default-true branch November 18, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards compatible Existing code and results keep working unchanged enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant