Skip to content

Historical Fire Maps: always listed in outputs(sim) - #110

Merged
eliotmcintire merged 1 commit into
developmentfrom
fix/fireMaps-plots-outputs
Nov 17, 2026
Merged

eliotmcintire merged 1 commit into
developmentfrom
fix/fireMaps-plots-outputs

Conversation

@eliotmcintire

Copy link
Copy Markdown
Collaborator

The historical fire maps figure was left off the run's list of saved files whenever its cache was reused. It is now listed on every run, and the maps are still only redrawn when the fire data change.

Affects: the "Historical Fire Maps" figure is in outputs(sim) on every run; no change to fits or other results.

Reuses: SpaDES.core Plots(useCache = TRUE, .cacheExtra = ) with the same key the outer Cache() used (attr(allFirePolys, "tags")).

Depends-on: PredictiveEcology/SpaDES.core#535

Technical details
  • Defect: fireSense_dataPrepFit.R:1955-1965 wrapped Plots() in Cache(omitArgs = "data"); on a hit Plots() never ran, so no outputs(sim) row.
  • Fix: the outer Cache() is removed and Plots() gets useCache = TRUE, .cacheExtra = attr(allFirePolys, "tags"), which checks the record before the maps are built (SpaDES.core#535).
  • Still to do before merge: raise the SpaDES.core@development floor in reqdPkgs to the version #535 merges as (older SpaDES.core would pass .cacheExtra on to terra::plot).
  • Checked: the file parses. Not run in a full module run.

🤖 Generated with Claude Code

…er Cache

The outer Cache() skipped Plots() on a hit, so the figure never reached
outputs(sim). Plots(useCache = TRUE, .cacheExtra = the fire polygons'
tags) skips building the maps on a hit and still records the figure.

Depends-on: PredictiveEcology/SpaDES.core#535

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eliotmcintire eliotmcintire added bug Something isn't working backwards compatible Existing code and results keep working unchanged labels Nov 17, 2026
@eliotmcintire
eliotmcintire merged commit 1fdfc3c into development Nov 17, 2026
9 checks passed
@eliotmcintire
eliotmcintire deleted the fix/fireMaps-plots-outputs branch November 17, 2026 21:58
eliotmcintire added a commit that referenced this pull request Nov 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards compatible Existing code and results keep working unchanged bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant