Repository navigation
Historical Fire Maps: always listed in outputs(sim) - #110
Merged
Merged
Conversation
…er Cache The outer Cache() skipped Plots() on a hit, so the figure never reached outputs(sim). Plots(useCache = TRUE, .cacheExtra = the fire polygons' tags) skips building the maps on a hit and still records the figure. Depends-on: PredictiveEcology/SpaDES.core#535 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added a commit
that referenced
this pull request
Nov 17, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The historical fire maps figure was left off the run's list of saved files whenever its cache was reused. It is now listed on every run, and the maps are still only redrawn when the fire data change.
Affects: the "Historical Fire Maps" figure is in
outputs(sim)on every run; no change to fits or other results.Reuses: SpaDES.core
Plots(useCache = TRUE, .cacheExtra = )with the same key the outerCache()used (attr(allFirePolys, "tags")).Depends-on: PredictiveEcology/SpaDES.core#535
Technical details
fireSense_dataPrepFit.R:1955-1965wrappedPlots()inCache(omitArgs = "data"); on a hitPlots()never ran, so nooutputs(sim)row.Cache()is removed andPlots()getsuseCache = TRUE, .cacheExtra = attr(allFirePolys, "tags"), which checks the record before the maps are built (SpaDES.core#535).SpaDES.core@developmentfloor inreqdPkgsto the version #535 merges as (older SpaDES.core would pass.cacheExtraon toterra::plot).🤖 Generated with Claude Code