Repository navigation
Fire pixels and the nonForestCanBeYoungAge check come from fireSenseUtils - #106
Merged
Merged
Conversation
…ls (PredictiveEcology/fireSenseUtils#239) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added a commit
that referenced
this pull request
Nov 16, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
eliotmcintire
added a commit
that referenced
this pull request
Nov 16, 2026
…eeping both bullets Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spread fit and the hindcasts use shared code to find which pixels burned and whether "recently burned" land is allowed to be non-forest, instead of each module keeping its own copy. Results do not change.
Affects: nothing for users; a small cleanup that lets the hindcast module share the fit's rules.
Depends-on: PredictiveEcology/fireSenseUtils#239
Technical details
allFirePixelsByYear()(R/youngAge.R) did the fire-source choice and the geometry check itself; both are now infireSenseUtils::firePixelsByYear()and the function is one call of it.stopIfNonForestCannotBeYoung()is nowfireSenseUtils::stopIfNonForestCannotBeYoung(), called fromprepare_SpreadFit()andprepare_IgnitionFit()and listed inprepSpreadFitData's.cacheExtra(the cache-key test requires every reached package function).addAnnualYoungAge()builds its table withfireSenseUtils::tsdTable()(also in the.cacheExtralist).fireSense_dataPrepPredictcalls the same functions (PredictiveEcology/fireSense_dataPrepPredict#46). The diff is separate from the open PR #105.Reuses:
fireSenseUtils::firePixelsByYear(),stopIfNonForestCannotBeYoung(),tsdTable(); new: none (code removed). Floor: set after fireSenseUtils#239 merges.Tests: the stop test moved to fireSenseUtils; the others unchanged. Full suite (
convertToPackage()+test_local(), scratch library with the fireSenseUtils branch): branch 512 pass, 0 fail, 1 skip (re-run after thetsdTable()change) (DPF_EQUIVALENCE_FIXTUREnot set; also skipped on base); base 513 pass, 1 fail (test-prepSpreadFitDataCacheExtra.R: a package function the module reaches is not in the cache key; fixed here by listingstopIfNonForestCannotBeYoung) with the same library.🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6