Disable msvc reproducibility check temporarily - #1564
Merged
TonyXiang8787 merged 1 commit intoSep 1, 2026
Merged
Conversation
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe
added
the
github_actions
|
figueroa1395
reviewed
Sep 1, 2026
figueroa1395
left a comment
figueroa1395
left a comment
Member
There was a problem hiding this comment.
@nitbharambe Can you run nightly on this just to check we didn't miss anything? After that I'll approve.
Member
Author
TonyXiang8787
approved these changes
Sep 1, 2026
TonyXiang8787
deleted the
pgm/feature/temporarily-disable-msvc-reproducibility-check
branch
September 1, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our nightly build intermittently fails because of reproducible build with msvc does not succeed.
Since clang-cl succeeds, there is atleast some way possible for windows users to get reproducible builds.
Hence lets disable this check, fix reproduciblity and then re-enable it again