Merge links into nodes: Documentation - #1553
Open
mgovers wants to merge 13 commits into
Open
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
added
documentation
mgovers
changed the base branch from
feature/link-registration-dual-code-path
to
main
August 26, 2026 14:03
mgovers
changed the base branch from
main
to
pgm/feature/link-supernode-output-enabled
August 26, 2026 14:06
…ture/link-supernode-docs
…ture/link-supernode-docs
Member
|
Let's also adjust the ordering of components after |
Base automatically changed from
pgm/feature/link-supernode-output-enabled
to
main
August 31, 2026 16:05
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Member
I believe I addressed it in 927e8e1 |
figueroa1395
marked this pull request as ready for review
September 1, 2026 08:57
Member
|
Throughout the documentation, we make reference to branches when talking about from/to side, flows, etc. Do we want to replace those with edges (or both) everywhere? |
|
| ```{note} | ||
| 1. Due to the high admittance of a `link` it is chosen that a power sensor cannot be coupled to a `link`, even though a | ||
| link is a `branch` | ||
| 1. Due to the high admittance of a `link` it is chosen that a power sensor cannot be coupled to a `link`. |
Member
There was a problem hiding this comment.
Suggested change
| 1. Due to the high admittance of a `link` it is chosen that a power sensor cannot be coupled to a `link`. | |
| 1. Due to the high admittance of a `link`, it is chosen that a power sensor cannot be coupled to a `link`. |
| It measures the active/reactive power flow of a terminal. | ||
| The terminal is either connecting an `appliance` and a `node`, or connecting the from/to end of a `branch` (except | ||
| `link`) and a `node`. | ||
| The terminal is either connecting an `appliance` and a `node`, or connecting the from/to end of a `branch` and a `node`. |
Member
There was a problem hiding this comment.
Suggested change
| The terminal is either connecting an `appliance` and a `node`, or connecting the from/to end of a `branch` and a `node`. | |
| The terminal is always connected to a `node` on the one side, and either `appliance`, or the from/to end of a `branch` on the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly scoped out: document the actual link solving algorithm.