Skip to content

Sync pgxntool to 2.2.0 - #21

Merged
jnasbyupgrade merged 3 commits into
Postgres-Extensions:masterfrom
jnasbyupgrade:update-pgxntool-2.2.0
Jul 29, 2026
Merged

Sync pgxntool to 2.2.0#21
jnasbyupgrade merged 3 commits into
Postgres-Extensions:masterfrom
jnasbyupgrade:update-pgxntool-2.2.0

Conversation

@jnasbyupgrade

@jnasbyupgrade jnasbyupgrade commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • git subtree pull pgxntool from https://github.com/Postgres-Extensions/pgxntool.git release tag, updating the embedded copy from 2.1.0 to 2.2.0. Conflicts resolved by taking upstream's version for every file under pgxntool/ (it's vendored, no local patches to preserve).
  • Ran pgxntool/update-setup-files.sh to reconcile setup-copied files against the new version: pruned pgxntool/.claude/ and pgxntool/.github/ (pgxntool's own dev-only tooling, not meant to be embedded in consumer projects). No other setup files (.gitignore, test/deps.sql) needed changes this time.

Verification

  • make builds cleanly.
  • make install && make installcheck (the same sequence CI's pg-build-test runs) passes all pgTAP tests on PG17, starting from a machine where the extension had never been installed before.

Heads up: found a make test ordering bug in pgxntool 2.2.0 (filed upstream, doesn't block this PR)

While testing locally, make test (not make install && make installcheck) genuinely failed pg_regress (extension "test_factory" is not available) the first time on a machine where the extension had never been installed. Root cause: check-stale-expected (new in 2.2.0, enabled by default) is added to TEST_DEPS before install, but its own prerequisite is installcheck -- so building it pulls installcheck forward, ahead of install, the first time through. A second make test run then passes, since install had already completed.

This repo's CI doesn't use make test/TEST_DEPS at all -- pg-build-test calls make install then make installcheck directly, which is the correct order and is what I re-verified above -- so it's unaffected. It will bite anyone running make test locally on a truly fresh checkout though. Happy to file this against pgxntool separately if useful, distinct from the already-open #49 (installcheck's exit code being swallowed).

Test plan

  • make
  • make install && make installcheck on a machine with no prior install
  • CI (this PR)

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3ba07a4b-70ad-427b-a901-3722f2784866

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

b67064b Release 2.2.0 (#77)
d949d6d Fix stale README/CLAUDE.md docs; rename internal-only test shim (#76)
6d7822c ci: grant actions:write so bun cache save succeeds (#75)
2738f59 README.asc: fix stale docs, document undocumented API surface (#74)
d1d3bee Add make pgxntool-version to print the embedded pgxntool version (#73)
493a0f8 Fix parallel-build SQL corruption, remote hardcoding, and add safety checks (#61)
3b0e3de Fix make pgtle PGTLE_VERSION=X being silently ignored (#66)
21b35ef ci: skip paired-test-PR requirement for doc-only PRs (#71)
55efd03 Rename EXTENSION_VERSION_FILES to EXTENSION__CURRENT_VERSION__FILES (#69)
9d0a856 Fix pgtle.sh rejecting non-numeric version aliases like 'stable' (#57) (#63)
9c2f75f Docs: versioned SQL file tracking tradeoffs and update-testing pattern (#60)
c38cf2a ci: never check out fork PR head in claude-code-review pull_request_target job (#70)
aab8f2b pgtle_versions.md: fix wrong uninstall_extension() version claim (#59)
e2c9174 README.asc: make tag creates a git tag, not a branch (#58)
eb84bc6 Stamp 2.1.0
9fbe6f4 Fix results ordering, control file whitespace, ENABLE_* override, debug levels (#31)
88bb4f2 Add Claude Code GitHub Actions workflows (#41)
af5bbbb ci: pass repo owners to run-tests.yml for fork-account matching (#40)
c7928af Fix repo-root guard to work inside a git worktree (#39)
b062fca ci: point reusable test workflow at @master
b6cdbfd Add CI workflows and multi-session PR guard (#33)
1ba0987 Stamp 2.0.3
1931cbe Fix pgxntool-sync remote and make it runnable without make (#37)
8176304 Stamp 2.0.2
3e142ab Fix parse_control_file: remove comments before stripping quotes (#27)
cacc301 Stamp 2.0.1
bf1db6b Fix bash 3.2 / Linux compatibility issues (#26)
62d0fcb Fix broken ifeq for --load-language=plpgsql on PG < 13 (#24)
121f0b3 Stamp 2.0.0
ad3ca7e Remove .source support; add test/install, test/build, and verify-results (Postgres-Extensions#18)
c010cf8 Fix bash 3.2 compatibility (#23)
abeb9d3 Remove .source file support from pg_regress integration (#22)
08c1879 Stamp 1.1.2
6e0dad2 Fix double --dbname bug that defeated unique test database names
639756c Stamp 1.1.1
6ba3176 Fix pg_tle exception handler and empty upgrade files (Postgres-Extensions#15)
3b8cb2a Stamp 1.1.0
550a901 Remove commit.md (maintained in pgxntool-test)
d73ca93 Add unique test database names to prevent conflicts (Postgres-Extensions#13)
9b344be Add update-setup-files.sh for 3-way merging after pgxntool-sync (Postgres-Extensions#12)
ab7f6e2 Stamp 1.0.0
3a571ba Add pg_tle support and modernize test infrastructure (Postgres-Extensions#11)
b96ea6d Add support for Claude code; build and doc improvements (Postgres-Extensions#9)
e9c24de Fix pg_regress on versions > 12 (Postgres-Extensions#5)
REVERT: bed3604 Fix pg_regress on versions > 12 (Postgres-Extensions#5) (Postgres-Extensions#6)

git-subtree-dir: pgxntool
git-subtree-split: b67064b16ca2eb30761c078511dc8c974938480f
…release

# Conflicts:
#	pgxntool/CLAUDE.md
#	pgxntool/HISTORY.asc
#	pgxntool/README.asc
#	pgxntool/README.html
#	pgxntool/base.mk
#	pgxntool/control.mk.sh
#	pgxntool/pgtle.sh
#	pgxntool/pgtle_versions.md
update-setup-files.sh pruned pgxntool/.claude and pgxntool/.github, which
are pgxntool's own dev tooling and not meant to be embedded in consuming
projects.
@jnasbyupgrade
jnasbyupgrade force-pushed the update-pgxntool-2.2.0 branch from 2e60b95 to 6f27479 Compare July 29, 2026 21:43
@jnasbyupgrade
jnasbyupgrade marked this pull request as ready for review July 29, 2026 21:44
@jnasbyupgrade
jnasbyupgrade merged commit 8578b83 into Postgres-Extensions:master Jul 29, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant