Skip to content

Fix make pgtle PGTLE_VERSION=X being silently ignored #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnasbyupgrade merged 2 commits into from
Jul 26, 2026
+8 −2
Merged

Fix make pgtle PGTLE_VERSION=X being silently ignored #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3c0b02
Fix make pgtle PGTLE_VERSION=X being silently ignored (#65)
jnasbyupgrade Jul 26, 2026
c31cc5d
Merge remote-tracking branch 'upstream/master' into issue-65-pgtle-ve…
jnasbyupgrade Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions HISTORY.asc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
STABLE
------
== Fix `make pgtle PGTLE_VERSION=X` generating all versions instead of one
`base.mk`'s `pgtle` target never passed the `PGTLE_VERSION` make variable
through to `pgtle.sh --pgtle-version`, so it silently generated all pg_tle
version ranges regardless of the value given on the command line.

== Rename `EXTENSION_VERSION_FILES` to `EXTENSION__CURRENT_VERSION__FILES`
The old name implied it listed every version file for an extension; it
actually only ever holds the current/most-recent one per extension. If your
Expand Down
5 changes: 3 additions & 2 deletions base.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,11 +328,12 @@ PGXNTOOL_EXTENSIONS = $(basename $(PGXNTOOL_CONTROL_FILES))
# Depend on 'all' to ensure versioned SQL files are generated first
# Depend on control.mk (which defines EXTENSION__CURRENT_VERSION__FILES)
# Depend on control files explicitly so changes trigger rebuilds
# Generates all supported pg_tle versions for each extension
# Generates all supported pg_tle versions for each extension, unless
# PGTLE_VERSION is set on the command line to limit output to one range
.PHONY: pgtle
pgtle: all control.mk $(PGXNTOOL_CONTROL_FILES)
@$(foreach ext,$(PGXNTOOL_EXTENSIONS),\
$(PGXNTOOL_DIR)/pgtle.sh --extension $(ext);)
$(PGXNTOOL_DIR)/pgtle.sh --extension $(ext) $(if $(PGTLE_VERSION),--pgtle-version $(PGTLE_VERSION));)

#
# pg_tle installation support
Expand Down
Loading