release skill: add fixed-issues line; fix Fixes-list GitHub gotcha everywhere - #54
Open
jnasbyupgrade wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…erywhere Add a "Compile the complete fixed-issues line" step to the /release skill, between reordering STABLE entries and stamping the version. Its purpose is for consumers of pgxntool: a single, complete, convenient list of every issue actually fixed in a release, independent of which changes were important enough to get their own narrated STABLE entry. Compiling that list requires unioning each merged PR's own `closingIssuesReferences` with a direct re-read of the PR body for `Fixes`/`Closes`/`Resolves` mentions -- and doing that surfaced a real, separate problem: GitHub only auto-closes the first issue in a single comma-separated line like `Fixes Postgres-Extensions#7, Postgres-Extensions#14, Postgres-Extensions#19`, silently dropping the rest with no error. 2.2.0 shipped with issues Postgres-Extensions#14, Postgres-Extensions#19, Postgres-Extensions#50, and Postgres-Extensions#53 all genuinely fixed by one PR whose body read `Fixes Postgres-Extensions#7, Postgres-Extensions#14, Postgres-Extensions#19, Postgres-Extensions#28, Postgres-Extensions#50, Postgres-Extensions#53` -- only Postgres-Extensions#7 auto-closed, and the other four sat open until a manual post-release audit caught it. The release skill's new step now also closes any such issue immediately rather than deferring it. Since that gotcha isn't specific to releases, document it everywhere a commit or PR might reference an issue: `commit-message-format.md` (commit messages) and `pr.md` (PR bodies) both now say to give each issue its own `Fixes #N` line, never a comma-separated list. Co-Authored-By: Claude <noreply@anthropic.com>
jnasbyupgrade
force-pushed
the
release-skill-fixed-issues-line
branch
from
July 29, 2026 22:38
8298f60 to
e95f188
Compare
jnasbyupgrade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Compile the complete fixed-issues line" step to the
/releaseskill, between reordering STABLE entries and stamping the version. Its purpose is for consumers of pgxntool: a single, complete, convenient list of every issue actually fixed in a release, independent of which changes were important enough to get their own narrated STABLE entry.Compiling that list requires unioning each merged PR's own
closingIssuesReferenceswith a direct re-read of the PR body forFixes/Closes/Resolvesmentions -- and doing that surfaced a real, separate problem: GitHub only auto-closes the first issue in a single comma-separated line likeFixes #7, #14, #19, silently dropping the rest with no error. 2.2.0 shipped with issues #14, #19, #50, and #53 all genuinely fixed by one PR (Postgres-Extensions/pgxntool#61) whose body readFixes #7, #14, #19, #28, #50, #53-- only #7 auto-closed, and the other four sat open until a manual post-release audit caught it. The release skill's new step now also closes any such issue immediately rather than deferring it.Since that gotcha isn't specific to releases, this also documents it everywhere a commit or PR might reference an issue:
commit-message-format.md(commit messages) andpr.md(PR bodies) both now say to give each issue its ownFixes #Nline, never a comma-separated list.Doc-only change, no behavior/test implications.