Add crossref-audit skill for catching cross-references missed by website merges - #40
Closed
jnasbyupgrade wants to merge 1 commit into
Closed
Conversation
…site merges /commit's two-phase cross-reference process only covers composing a PR branch's own commits before merge -- it can't help once merging happens via the GitHub website, outside AI control, which is how PRs actually land here now. There was no process for catching a paired commit that merged without its cross-reference until this was caught manually on issue Postgres-Extensions#57's fix (pgxntool commit a3e4062 landed without referencing its pgxntool-test coverage in PR Postgres-Extensions#30). Adds a new crossref-audit skill: find the last release tag in each repo, list commits since it, identify genuinely paired commits (a real code+test relationship, not just similar-sounding independent fixes), and check each side references the other. Single missing tip-of-master commit newer than the last release can be fixed directly (amend + force-push, verified content-identical first); more than one missing, or anything at/before the last release, always stops and asks rather than acting. Also documents in CLAUDE.md that PR merges happen outside AI control in this workflow, and points to the new skill at session startup and before any master-rebase. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Folded into #39 — these were directly related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/commit's two-phase cross-reference process only covers composing a PR branch's own commits before merge -- it can't help once merging happens via the GitHub website, outside AI control, which is how PRs actually land here now. There was no process for catching a paired commit that merged without its cross-reference until this was caught manually on issue #57's fix (pgxntool commita3e4062landed without referencing its pgxntool-test coverage in PR #30).Adds a new
crossref-auditskill: find the last release tag in each repo, list commits since it, identify genuinely paired commits (a real code+test relationship, not just similar-sounding independent fixes), and check each side references the other.Also documents in CLAUDE.md that PR merges happen outside AI control in this workflow, and points to the new skill at session startup and before any master-rebase.
Doc/skill-only change, no code changes.