RELEASE.md: document PGXN_REMOTE for tag/dist targets - #18
Merged
Conversation
origin in this checkout is the jnasbyupgrade fork, not the canonical Postgres-Extensions/pg_count_nulls repo, so make tag/make dist have always been one `git remote -v` slip away from tagging the wrong repo. pgxntool 2.2.0 (Postgres-Extensions/pgxntool#53) made the tagging targets' remote configurable via PGXN_REMOTE instead of hardcoding origin, so this sets PGXN_REMOTE = upstream here and drops the RELEASE.md step that relied on the release-runner remembering to check origin by hand.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ttern Hardcoding PGXN_REMOTE = upstream in the Makefile bakes in an assumption specific to this maintainer's clone (that origin is the jnasbyupgrade fork), which doesn't generalize to anyone else's checkout. Following Postgres-Extensions/cat_tools#52: leave the Makefile untouched (PGXN_REMOTE still defaults to origin via pgxntool's base.mk) and instead document in RELEASE.md that whoever runs the release should pass PGXN_REMOTE=upstream on the command line when their origin is a personal fork.
jnasbyupgrade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
origin in this checkout is the jnasbyupgrade fork, not the canonical Postgres-Extensions/pg_count_nulls repo, so make tag/make dist have always been one
git remote -vslip away from tagging the wrong repo. pgxntool 2.2.0 (Postgres-Extensions/pgxntool#53) made the tagging targets' remote configurable viaPGXN_REMOTEinstead of hardcodingorigin, so this documents passingPGXN_REMOTE=upstreamat release time in RELEASE.md, matching the pattern in Postgres-Extensions/cat_tools#52 rather than hardcoding the remote name into the Makefile (which would bake in an assumption specific to this maintainer's clone).Stacked on #17 (the pgxntool 2.2.0 bump) since
PGXN_REMOTEdoesn't exist before that version — base.mk previously hardcodedoriginwith no override.