docs(config): clarify maxRetries scope - #776
Merged
dustinbyrne merged 3 commits intoSep 11, 2026
Merged
Conversation
3 tasks
Contributor
|
Reviews (1): Last reviewed commit: "chore(config): deprecate maxRetries" | Re-trigger Greptile |
dustinbyrne
added this pull request to stack #777
September 10, 2026 19:04
turnipdabeets
approved these changes
Sep 10, 2026
dustinbyrne
force-pushed
the
chore/deprecate-max-retries
branch
from
September 10, 2026 22:35
b95873c to
b47d6a1
Compare
Contributor
|
Contributor
posthog-android Compliance ReportDate: 2026-09-10 22:42:43 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Stacked on #740; companion clarification: PostHog/posthog-ios#819.
Clarify that core
PostHogConfig.maxRetriescontrols push-subscription registration retries, with a default of3. It does not limit event, replay, or log ingestion retries. Retryable ingestion failures retain queued records for later flush triggers, subject to backoff; capacity is controlled bymaxQueueSizefor events/replay andlogs.maxBufferSizefor logs.The stack base already implements this behavior and includes its release notes. This PR clarifies the API documentation.
💚 How did you test it?
make testJava— all 958 core tests in 53 classes passed.make checkFormatand./gradlew :posthog:apiCheck— passed.-Xlint:deprecation -Werror; JVM public signatures match the stack base exactly.Checks used JDK 17. Android-specific tests and the compliance-adapter build were not run.
📝 Checklist
🤖 Agent context
Autonomy: Human-driven (agent-assisted).
Implemented with Pi and reviewed by a fresh read-only Pi reviewer. Tooling: Git, GitHub CLI, Make, Gradle, and Java compiler checks.