Notebook update - #66
Merged
Merged
Conversation
Keep the updated dataset URL (provabgs_legacysurvey_eval_v2_cleaned.fits). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
amina1315
added a commit
to amina1315/AION
that referenced
this pull request
Aug 15, 2026
* minor tweak * update readme * Update publish-pypi.yml * Update pyproject.toml * Adding more information on pypi page * Update README.md * Update README.md * Update README.md * updating readme slightly * fix formatting issues * Created using Colab * improve documentation * fixing formatting * Update README.md * Readme updates (PolymathicAI#52) * improving Readme for release * small update * fix alignment * simplify * Readme updates (PolymathicAI#53) * improving Readme for release * small update * fix alignment * simplify * adding acknowledgements * Created using Colab * updating notebook * Readme updates (PolymathicAI#54) * improving Readme for release * small update * fix alignment * simplify * adding acknowledgements * adding arxiv link * add spectrum preprocessing fns * add pad length for SDSS and DESI spectra * preprocessing in torch * make padding operate on Spectrum class; apply padding in codec * fix assignment * fix edge case * updating notebook (PolymathicAI#65) * Notebook update (PolymathicAI#66) * updating notebook * updating dataset --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Created using Colab * fix(spectrum): use 'wavelength' key in pad_spectrum sentinels `pad_spectrum` looks up sentinel values in `padding_values` while iterating over the attribute names of `Spectrum` (`flux`, `ivar`, `mask`, `wavelength`), but the dict key is `"lambda"`, so the `wavelength` lookup misses and the wavelength tensor is padded with the default `0` instead of the intended `99999`. That makes the wavelength array non-monotonic (`[real_min, …, real_max, 0, 0, …, 0]`). `LatentSpectralGrid.to_latent` feeds it to `interp1d`, whose out-of-range mask is `(xnew < x[..., 0]) | (xnew > x[..., -1])`. With `x[..., -1] == 0`, every latent grid position satisfies `xnew > 0` and the whole latent representation is replaced with `mask_value = 0.0`. Every spectrum then encodes to (essentially) the same null embedding. This shows up in downstream consumers that call the spectrum codec on inputs whose length is less than `pad_length` (so `F.pad` actually appends elements). Switching the dict key to `"wavelength"` so it matches the attribute name fixes the sentinel. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Update README.md --------- Co-authored-by: lhparker1 <liamholdenparker@gmail.com> Co-authored-by: Francois Lanusse <EiffL@users.noreply.github.com> Co-authored-by: Francois Lanusse <fr.eiffel@gmail.com> Co-authored-by: Jeff Shen <jshen2014@hotmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Tom Hehir <148493038+tom-hehir@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.