Repository navigation
Conversation
Collaborator
|
A note for this branch: #10277 (merged today) changed the Virginia rebate, and three of its files are also in this PR.
So this branch needs |
MaxGhenis
marked this pull request as ready for review
October 21, 2026 00:52
This was referenced Oct 21, 2026
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP draft: implementation is pushed at
9671c54167e1401b7a07b3dd78d35367095f542c; local validation is partial and remaining files are handed to the hub. Hub impact and parity checks remain pending.Parameter backdating lets several rebates reduce tax before their first eligibility year, such as Virginia's $250 rebate in 2020. Add the U6 historical guards for Colorado sales refunds, Illinois income/property rebates, New Mexico's three rebates, Virginia, Hawaii Act 115, and Massachusetts premium pay. Add the exact timing metadata, corrected MA Chapter 62F references, and the outside-modeler note/inventory.
Invariants, relative to merged main
ce9377ee80157a17eb730fa1b8550b4d433c696c:Plan and validation:
9671c54167e1401b7a07b3dd78d35367095f542c: 24 passed in 47.71s in the isolated child. The checked numeric schedules are unchanged upstream.23a530ae1401fe1bbf8cc683b22d775fb6497bb7. Fresh merged-head evidence: 17 files / 114 passes on9671c54167e1401b7a07b3dd78d35367095f542c. 64 files remain without a successful result because local validation stopped for the job window; seeremaining-state-test-files.txtfor the hub handoff.The runner preloads the baseline and Core's standard model/cache clone once in an untouched parent. The parameter checks and each YAML file run in separate serial children; the parent runs no tests or calculations, copy-on-write keeps mutations child-local, and named reforms use Core's normal factory. The parent waits for every child, so test processes never overlap.
The committed Python coverage reuses the existing global model and stays in the existing
policy-parametersCI group. Pre-merge local Python 3.13.9 / Core 3.33.2 measurement: 24 passed in 2.27s, 145.93s including startup/model loading. Peak memory was unavailable because the system query was denied. This is not a before/after benchmark; the prior Linux CI group passed 56 tests in 185.57s wall time at 5,685,736 KiB peak RSS. No CI runners or workflows changed.No microsimulation runs locally; the hub runs impact validation, and default data may not measure 2020–2021. The uniform pre-rebate output remains outside this PR.
axiom: TheAxiomFoundation/rulespec-us#1852 queued (Illinois rebates); TheAxiomFoundation/rulespec-us#1853 queued (New Mexico rebates); TheAxiomFoundation/rulespec-us#1854 queued (Virginia rebate); TheAxiomFoundation/rulespec-us#1855 queued (Massachusetts premium pay); TheAxiomFoundation/rulespec-us#1530 queued, extended with a comment (Colorado historical availability); TheAxiomFoundation/rulespec-us#1685 queued, extended with a comment (Hawaii historical eligibility). Corpus source admission or release re-pin and signed encoder dispatch remain pending. Documentation, metadata and citation-only edits are n/a.