Skip to content

Read the newest certified variant from the index in the results-PR tests - #201

Merged
MaxGhenis merged 1 commit into
mainfrom
w6/results-pr-tests-live-newest
Oct 21, 2026
Merged

MaxGhenis merged 1 commit into
mainfrom
w6/results-pr-tests-live-newest

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Read the newest certified variant from the index in the results-PR tests

This PR is stacked on #196; after #196 merges it retargets to main. Its diff is one commit to tests/test_uk_replay_results_pr.py.

The first automated results PR, #195 (policyengine.py 6.7.5), failed 55 tests. #199 fixes the 25 in the discover tests. This PR fixes the 30 in this file, minus the matrix-edit round trip that #196 removes. Every one named 6.5.0 as the newest certified variant, or as the last committed one. None of them had anything to do with 6.7.5's results.

Test Was Now
end-to-end harness (about 25 tests) certified a synthetic 6.6.0, refused as older than 6.7.5 VERSION is one minor version above the newest certified
NEWEST/COMMITTED round trip stripped 6.5.0's lines uses qualify.latest_certified and the index's last two ids
paragraph placement expected 6.5.0's closing sentence last the paragraph must sit directly before the subsection's next heading
happy path's COMMITTED check "pe6.5.0…", then the new id the index's last id, then the new id
older-version refusal "older than the newest certified 6.5.0" names the live newest version

PE641 and PE650 stay where a test reproduces the hand-built #188 and #190, or uses 6.5.0's committed record as a template.

Verified

Fleet ops' disk pause #9 rules out local test runs, so CI is the evidence:

After #196, #199 and this PR merge, #195 is closed and its branch deleted, and the results workflow is re-dispatched for its request. A force-push rebuild would have to change ci.yml relative to #195's old tip, and the bot's token no longer holds workflows. The bot then opens a fresh 6.7.5 PR, which lands on the normal gates.

axiom: n/a: test fixtures only; no policy encoding.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
policyengine-scorecard Ready Ready Preview Oct 21, 2026 6:56pm UTC

Request Review

The first automated results PR (#195, 6.7.5) failed 30 tests in this file
that named 6.5.0 as the newest certified variant or the last committed
one: the end-to-end harness certified a synthetic 6.6.0, now refused as
older than 6.7.5; the NEWEST/COMMITTED round trip stripped 6.5.0's lines;
the paragraph-placement test expected 6.5.0's closing sentence last.

Those tests now read the committed index: NEWEST_ID is
qualify.latest_certified, the COMMITTED round trip uses the index's last
two ids, the paragraph must sit directly before the subsection's next
heading, the synthetic release is one minor version above the newest
certified, and the older-version refusal names the live newest version.
PE641 and PE650 stay where a test reproduces the hand-built #188 and #190.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis
MaxGhenis force-pushed the w6/results-pr-tests-live-newest branch from 5c10b3f to 00afa36 Compare October 21, 2026 18:55
@MaxGhenis
MaxGhenis changed the base branch from w6/engine-matrix-from-index to main October 21, 2026 18:55
@MaxGhenis
MaxGhenis merged commit fdcdea2 into main Oct 21, 2026
22 of 28 checks passed
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Merged by squash at head 00afa363 (merge commit fdcdea29).

Next: #202 is rebased onto main and retargeted. Then comes the 6.9.0 results rebuild.

🤖 Generated with Claude Code

This branch was successfully deployed

1 active deployment
Preview — 00afa363 Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant