Repository navigation
Count only released_bundle requests in discovery; answer the nits on #165 - #192
Merged
Merged
Conversation
…3f21a7 W4 (2026-10-16): a pre-promotion candidate request names the version the candidate will be released as, but pins the candidate's wheels; push.yaml rebuilds the released wheel. Counting candidate requests for deduplication and the floor would let a missed release dispatch skip the released version. Both pipeline/uk_replay_discover.requested_versions and the write job's guard now count only released_bundle requests, in any status. Nits from the review of f3f21a7: - N1/N2: the docs say a yanked release still counts toward the floor, a version PyPI no longer lists stops counting, and the floor qualification sits next to the floor sentence. - N3: requests are content-addressed, so recovery is removal, not editing. - N4: a published, requested epoch version cannot raise the floor. - N5: a Hypothesis property over published and requested sets checks the floor and that no released_bundle-requested version repeats. - #190's stale comment in the determinism test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…nits on 23cff0a - The guard test now stores a candidate, an unsupported-kind and a kind-less request; none covers the release (mutants G3, G4 now fail). - Kind-less, null-kind and miscased-kind stored requests cover nothing in discovery (mutant D3 now fails). - The floor property draws repeated versions (a candidate and a released_bundle request for one version), unsupported and missing kinds, and versions PyPI never published. - The renamed floor test says what it asserts. - Docs, the enqueue script's comment and the floor_versions docstring say a candidate request does not cover the released version, that the grace period reduces but does not rule out a late duplicate, and that a certified version suppresses older releases whatever PyPI lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 16, 2026 10:32
Contributor
Author
|
Merge audit (W6). Base
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #191 (missed-dispatch discovery, landed from #165).
Released-bundle requests only (W4)
W4 pointed out a problem with the merged rule, which counted a request of any kind for deduplication and the floor. A pre-promotion
candidaterequest names the version the candidate will be released as, but it pins the candidate's wheels, andpush.yamlrebuilds the released wheel. So the merged rule would let a missed release dispatch skip the released version, whose bytes are what need replaying.Now only
released_bundlerequests, in any status, count, both inpipeline/uk_replay_discover.requested_versionsand in the write job's guard (.github/scripts/uk_replay_discovery_guard.py).released_bundledispatch dedupes discovery whenever it lands before discovery's push. The 6-hour grace period, which W4 asked to keep, makes a later dispatch unlikely but does not rule it out; the docs say so.released_bundledispatch.Nits from the review of f3f21a7
QUALIFICATION_INTERFACE.md.1!0.1cannot raise the floor; the epoch check is what excludes it.Validation
test_uk_replay_discover,_discovery_workflow,_discovery_scripts,_queueand_determinism, 192 passed.axiom: n/a: replay receiver CI; no policy encoding.
🤖 Generated with Claude Code