Repository navigation
Cite d1981 in the NZ non-wage money ageing disclosures - #1425
Merged
Merged
Conversation
Max ruled d1981 on 2026-10-26 (option A). The listed non-wage donor
money columns age from calendar 2024 to tax year 2026-27 by d1599's AWE
convention, factor 1.079073 (1.077090 low, 1.081052 high), disclosed as
interim. A hold-fixed run (factor 1) sits beside it as a pre-declared
sensitivity.
The four index-family disclosures in nz/money_normalization.json said
"provisional pending Max's ruling on non-wage ageing (H3)". They now
cite the ruling and the sensitivity it pre-declares. They also say that
no profile here carries the hold-fixed run yet: the schema allows an
identity per family, not per profile, and the money kernel reads an
identity's reason from the family entry. Wiring it falls to G8-w3,
which first runs NZ transport. The wording also moves to active voice
("ages by").
The donor factors already match the ruling:
reference_aging.json's donor_cy2024_to_ty2027_{low,central,high} carry
operational factors 1077090, 1079073 and 1081052 over 10**6. No factor,
column or rate changes.
test_nz_money_normalization.py now pins the ruling's phrase and the
sensitivity, and refuses "provisional". The NZ golden moves only
money_normalization.json's hash and the spec fingerprint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Act on the independent review of e9c18d4 (APPROVE_WITH_NITS): - Each disclosure now ends on a full sentence: "Max's ruling d1981 (2026-10-26) adopts this as an interim convention and pre-declares a hold-fixed sensitivity (factor 1), which no profile here carries yet (G8-w3)." - The test pins that whole clause too. Dropping "which no profile here carries yet (G8-w3)" from one family now fails it. - ruff format keeps the test file clean. - The unreleased changelog fragment nz-money-normalization.added.md still called non-wage ageing provisional. It now says ruling d1981 adopts AWE growth as the interim index and pre-declares the hold-fixed sensitivity. The NZ golden again moves only money_normalization.json's hash and the fingerprint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Act on the delta review of cb0619c: the fragment now says, as the disclosures do, that no profile carries the hold-fixed sensitivity yet, and the paragraph wraps at 80 columns again. Apart from that clause, the words don't change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
force-pushed
the
nzhub/d1981-disclosures
branch
from
October 29, 2026 19:20
1e226b2 to
a46343b
Compare
Only tests/golden/nz_country_spec.json conflicted: #1398 and this PR both move the NZ spec fingerprint. The NZ hub regenerated the golden from the merged spec with the golden test's own _loaded_spec_summary and canonical_json_bytes. Against main it moves only the fingerprint and money_normalization.json's hash (5e817f0b…). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
force-pushed
the
nzhub/d1981-disclosures
branch
from
October 29, 2026 19:20
a46343b to
3142d49
Compare
MaxGhenis
marked this pull request as ready for review
October 30, 2026 02:10
Contributor
Author
|
Merged by the NZ hub (session local_e407a527) at 3142d49 with --merge. Gates: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands after #1398, because both change the NZ golden (
tests/golden/nz_country_spec.json). #1398 landed at 19:00:55Z on 2026-10-29, and 3142d49 mergesmain(3088868) with the golden regenerated.What changes
Max ruled d1981 on 2026-10-26 (option A). The listed non-wage donor money columns age from calendar 2024 to tax year 2026-27 by d1599's AWE convention, factor 1.079073 (1.077090 low, 1.081052 high), disclosed as interim. A hold-fixed run (factor 1) sits beside it as a pre-declared sensitivity.
nz/money_normalization.json(mixed_income,capital_income,pensions,owner_housing_costs) said "provisional pending Max's ruling on non-wage ageing (H3)". Each now says "Max's ruling d1981 (2026-10-26) adopts this as an interim convention and pre-declares a hold-fixed sensitivity (factor 1), which no profile here carries yet (G8-w3)." The wording also moves to active voice ("ages by").test_nz_money_normalization.pypins the ruling's sentence, including the clause that no profile carries the sensitivity yet, and refuses "provisional".changelog.d/nz-money-normalization.added.mdcalled non-wage ageing provisional. It now says ruling d1981 adopts AWE growth as the interim index and pre-declares the hold-fixed sensitivity, which no profile carries yet.money_normalization.json's hash and the spec fingerprint.reference_aging.json'sdonor_cy2024_to_ty2027_{low,central,high}already carry operational factors 1077090, 1079073 and 1081052 over 10**6, the ruling's values.Why the hold-fixed run isn't wired here
money_normalization.validate_money_normalizationaccepts an identity per index family, with no profiles, or a factor id per declared profile. It refuses an identity for one profile.transport/money_kernels.pyreads an identity's reason from the family entry. So this resource can't carry a hold-fixed profile beside the AWE profiles as it stands. The independent review found two routes that touch neither module:money.normalize@1node. The validator accepts it. It needs graph wiring, which G8-w3 does anyway.aging_indexprofile mapped to a unit factor. It needs a generator change, gives a receipt that labels a calendar-2024 schedule as target 2027, and overloads the sharedaging_indexdimension:reference_profileswould refuse the new profile until the IRD wage-band ageing gains one too.Either way, the wiring belongs to G8-w3, which first runs NZ transport. The resource's status already says no NZ transport graph reads it yet. The disclosures say the sensitivity isn't carried yet, so they don't imply it is.
Verification
packages/*/srcplus the repo root), the NZ hub ran 12 engine-free files:test_nz_money_normalization,test_money_normalization,test_country_spec,test_nz_spec_package,test_spec_only_country_packages,test_spec_source_citations,test_transport_money_kernels,test_reference_profiles,test_calibration_columns,test_spec_engine_country_bundles,test_nz_reference_agingandtest_reference_factors. 1,995 passed, 16 skipped, 0 failed.main's disclosures restored under the new test,test_every_family_uses_the_donor_factor_for_its_profile_with_a_disclosurefails. With this PR's disclosures, all 17 tests in the file pass.ruff check .andtools/ci_test_plan.py verifypass.git grep).Review
jobs/review-microcosm-1425): APPROVE_WITH_NITS. All five claims held.main's resource, the test failed.git grepfound no stale pins. Six files passed, 473 tests in all.hold_fixedselection raises an unknown-profile error.ruff formatand the overstated "needs a schema change". cb0619c fixes all four.mainafter Reconcile regional Census family-type counts under d1932 #1398. Only the golden conflicted: Reconcile regional Census family-type counts under d1932 #1398 and this PR both move the NZ fingerprint. The hub regenerated it from the merged spec. Againstmain, it moves only the fingerprint andmoney_normalization.json's hash, 5e817f0b…, the same hash as before the merge.main, out of 3,638 paths.NZ_CHRONICLE_ARTIFACT.Checklist
mainafter Reconcile regional Census family-type counts under d1932 #1398 and regenerate the golden.🤖 Generated with Claude Code