Repository navigation
feat(header): readable glass menus, mobile menu fixes and a single h1 - #214
Merged
BIA3IA merged 5 commits intoNov 2, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
viganogabriele
force-pushed
the
feat/chrome-visual-refinement
branch
from
October 31, 2026 11:13
0217fe3 to
ba34370
Compare
This was referenced Oct 31, 2026
viganogabriele
marked this pull request as ready for review
October 31, 2026 17:54
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 13:53
f92325f to
b269c65
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
2 times, most recently
from
November 2, 2026 14:06
421a974 to
76d60f2
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
2 times, most recently
from
November 2, 2026 14:20
36f22d9 to
5bde9d0
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
2 times, most recently
from
November 2, 2026 14:32
3f618b9 to
9bf0f7e
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 14:32
5bde9d0 to
8c86923
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
from
November 2, 2026 14:35
9bf0f7e to
cd3cd33
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 14:56
468495e to
35e8f73
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
from
November 2, 2026 14:56
cd3cd33 to
3c4f49b
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 15:00
35e8f73 to
d8178b0
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
2 times, most recently
from
November 2, 2026 15:02
4689f8c to
d4e4e2c
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 15:14
1b62fea to
805bbd8
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
from
November 2, 2026 15:14
d4e4e2c to
91f5fac
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 15:19
805bbd8 to
624cbf7
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
from
November 2, 2026 15:19
91f5fac to
575ed3f
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 15:26
624cbf7 to
4c3271d
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
from
November 2, 2026 15:26
575ed3f to
3af2924
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 15:28
4c3271d to
f1758be
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
2 times, most recently
from
November 2, 2026 16:03
e2e77c2 to
7eec5ce
Compare
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 16:03
f1758be to
65a1d49
Compare
… layout The standalone download page kept its own title steps (45px up to 1023px, then 120px) and 48px side margins. It now uses the fluid display scale and the shared container gutters, stays centered with padding for short screens, and its title is the page's h1 (header and footer are hidden here). CardSplit, used only by this page, tightens its stacked phone layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It was the third page-title implementation, with its own gradient and sizes. Hero already fits long words to the width.
Hero wrapped the title onto three lines at 320px and pushed the download button below a 320x568 screen. This standalone page has no header, so it keeps its fluid title; a comment now says why.
The header sat inside the page wrapper (isolate + overflow-clip), where Chromium skipped its backdrop: the glass never blurred, so the page titles read sharp through the open menus. It now renders outside the wrapper and the open panels use a stronger blur, keeping the glass. The mobile menu closes on navigation and on Escape, exposes aria-expanded and uses 40px rows without the blue gradient labels. The current page and its section are marked, "Appunti" gets the external arrow, and the language and theme buttons, which only logged to the console, are removed. The logo is no longer an h1: the page Hero is, so every route has exactly one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The menu closes when any link in it is followed, the current page and the logo included, when tapping outside it and when focus leaves it. Before, Back reopened it and the current-page link left it open. - Escape returns focus to the toggle instead of dropping it on <body>. - Menu links get the site's focus ring: the active item was already underlined, so focusing it changed nothing. The desktop dropdown links get an outline for the same reason. - The open menu's scroll no longer moves the page underneath. - Glass forwards a ref.
BIA3IA
force-pushed
the
feat/guida-matricola-visual-refinement
branch
from
November 2, 2026 16:05
65a1d49 to
b1de36d
Compare
BIA3IA
force-pushed
the
feat/chrome-visual-refinement
branch
from
November 2, 2026 16:05
7eec5ce to
5a20d3c
Compare
Base automatically changed from
feat/guida-matricola-visual-refinement
to
feat/home-visual-refinement
November 2, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #213:
feat/guida-matricola-visual-refinement. This is the header part of the shared site chrome. The footer is in #215 and the 404 page and document language are in #216. This PR used to contain all three; it has been split.Why the glass "didn't work"
The header sat inside the page wrapper in
layout.tsx(relative isolate … overflow-clip). In that position Chromium skipped its backdrop, so the glass never blurred anything (thebackdrop-filterwas set, but nothing was blurred). With the mobile menu or a desktop dropdown open, the page titles read sharp through the links (see the 402 before shot).I bisected it in the browser: removing
isolationalone only helped partly, while rendering the header outside the wrapper fixes it. So<Header />now renders before the wrapper. The header isfixed, so the layout is unchanged. The glass stays everywhere. The open panels only get a stronger blur (backdrop-blur-xl). An earlier revision of this PR used a solid background instead; that is reverted.Other changes
aria-expanded,aria-controlsand an Italian label, and it is a 40 px target with a focus ring.aria-current="page"and the underline, and on desktop the trigger of its section stays underlined.console.log. There is no i18n, and dark mode is disabled pending design. They can return with those features.h1on every page, mobile and desktop copies included. It is now aspan, with a decorativealt=""and a focus ring.h1per page: the sharedui/hero.tsxtitle becomes theh1, so every route has exactly one (checked on 17 routes). Same classes, no visual change.<ul><Glass><li>becomes<Glass><ul><li>.Screenshots (before | after, on /storia)
Verification
aria-expandedtoggles, and there is oneh1per route.pnpm check,pnpm build,pnpm typecheckand the tests (3/3) all pass.Merge order
#199 → … → #213 → this → #215 → #216. The
pr-assets/chrome-visual-refinementbranch only holds the screenshots.🤖 Generated with Claude Code