Repository navigation
fix(storia): match hero title to Figma and tidy chapter cards - #190
Merged
Merged
Conversation
Center the history hero and use display/extralarge for the title where it fits on one line, as in Figma. Draw the Hero title gradient per line so wrapped titles keep the full effect on every page. Point the 'Conosci le persone' arrow down, since it scrolls to the boards section, and cap the chapter visuals width so the cards next to the timeline are not stretched.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe Storia page updates its hero styling and link icon, replaces the organization image with responsive charts, and constrains the visual grids in its six timeline chapters. ChangesStoria page presentation
Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 4 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies the main /storiachanges: aligning the hero title with Figma and updating chapter cards. It is concise, specific, and consistent with the pull request objectives.Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Replace the organigramma image with CardIcon nodes connected by rails and arrows, with a stacked layout below lg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corregge la tipografia dell’hero, la freccia del collegamento ai direttivi e la larghezza delle card accanto alla timeline di
/storia.xl: testo a sinistra, tre ritratti a destra; sotto questo breakpoint i contenuti sono impilati.Verifica: TypeScript e Biome passano; layout controllato a 1440 e 390 px senza overflow, con foto affiancate su desktop e impilate su mobile. Restano invariati i segnaposto dei mandati storici per cui non sono disponibili nomi e ruoli verificati.