Repository navigation
refactor(telegram)!: remove legacy commands and anonymous backend access - #157
Merged
Merged
Conversation
…ecisions Completes RFC v3 Phase 4b step 4 and prepares the bot for Phase 5 (LEGACY_ANONYMOUS=deny). - Remove /addrole, /delrole, /link and /test_db. - Drop overrideGroupAdminCheck: per RFC §4 decision 5, tg_group_admins is replaced by the native Telegram admin shortcut (decision 2). - Remove the shadow/anonymous decision modes, IDP_DECISIONS and legacyBackend; every check applies the IdP decision. - The socket always authenticates with its token. BREAKING CHANGE: IDP_PUBLIC_URL, OAUTH_BACKEND_RESOURCE_URI, OAUTH_BOT_CLIENT_ID and OAUTH_BOT_PRIVATE_JWK are required; IDP_DECISIONS is removed. Deploy before setting backend LEGACY_ANONYMOUS=deny.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe bot now requires IdP configuration and uses authenticated backend access. Commands, middleware, and operational flows use IdP permissions instead of legacy role checks. The ChangesIdP Authorization Cutover
Sequence Diagram(s)sequenceDiagram
participant Command
participant authorizeAction
participant Backend
participant idpDecision
Command->>authorizeAction: actor, chat, and required permissions
authorizeAction->>Backend: resolve actor access
Backend-->>authorizeAction: access entry
authorizeAction->>idpDecision: access entry, permissions, and chat-admin status
idpDecision-->>authorizeAction: allowed or denied decision
authorizeAction-->>Command: authorization result
Priority: ➖ Normal Change: Other Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 70.59% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 45 files. (3 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title accurately and concisely describes the main changes: removing legacy commands and anonymous backend access. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 70.59% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 45 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
toto04
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes RFC v3 Phase 4b step 4 and prepares the bot for Phase 5 (
LEGACY_ANONYMOUS=deny)./addrole,/delrole,/linkand/test_db.overrideGroupAdminCheck: per RFC §4 decision 5,tg_group_adminsis replaced by the native Telegram admin shortcut (decision 2), whichallowTelegramChatAdminsalready provides.IDP_DECISIONSandlegacyBackend. The IdP variables are now required and every check applies the IdP decision; an unavailable decision denies./audit,tg.auditLog.createand thetest.dbQueryhealth check. The socket always authenticates with its token.Roletype and the dead role declarations on commands.The bot no longer calls
tg.permissions.*,tg.link.*,tg.groupLabels.*,auth.*,test.*ortg.auditLog.create, and sends no actor fields in requests. Older audit rows and socket payloads are still read withadminId/performerIduntil the v2 SDK.Deploy
Works with the current backend (token sockets and
tg.access.resolveare already accepted). Deploy before the backend switches toLEGACY_ANONYMOUS=deny; rolling back to an older bot image needsLEGACY_ANONYMOUS=allow.BREAKING CHANGE:
IDP_PUBLIC_URL,OAUTH_BACKEND_RESOURCE_URI,OAUTH_BOT_CLIENT_IDandOAUTH_BOT_PRIVATE_JWKare required;IDP_DECISIONSis removed.Verification
typecheck, biome check, 184 tests (1 optional Redis test skipped), build. Also typechecked against the Phase 5 backend SDK. Not verified against a real IdP, backend or Telegram.