Repository navigation
Conversation
This is an empty commit to trigger the publishing of the new package with breaking changes (no legacy support) BREAKING CHANGES
The commit analyzer used the default angular preset, which ignores the `!` in the header and only accepts a `BREAKING CHANGE:` footer with the colon. #88 (`feat(auth)!: …`) triggered no release, and the follow-up commit with a `BREAKING CHANGES` footer was read as a plain feat and published 1.13.0. The analyzer and the release notes now use the conventionalcommits preset, which reads both forms.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release.config.mjsused the commit analyzer without a preset, so semantic-release fell back to angular. Angular ignores the!in the header and only accepts aBREAKING CHANGE:footer with the colon.feat(auth)!: …, footerBREAKING CHANGEwithout the colon) → "should not trigger a release".feat: publish breaking changes(footerBREAKING CHANGESwithout the colon) → read as a plainfeat→ published 1.13.0, which already contains the breaking changes of feat(auth)!: enforce IdP tokens and drop legacy procedures (RFC v3 Phase 5) #88.v1.13.0tag still points to the old commit (8922d26), which is no longer onmain, so the next run failed withtag 'v1.13.0' already exists.Change
@semantic-release/commit-analyzerand@semantic-release/release-notes-generatorusepreset: "conventionalcommits", which reads bothtype!:and theBREAKING CHANGE:footer.conventional-changelog-conventionalcommitsadded to devDependencies (the workflow runsnpx semantic-releaseafterbun install).From now on a
!in the PR title is enough to release a major.Verification
semantic-release 25 dry-run on this branch with the new config (npm and github plugins left out):
v1.13.0is not reachable frommain, so once this PR is merged the release starts fromv1.12.0and publishes 2.0.0, with no extra commit needed.After the merge
@polinetwork/backend@2.0.0npm deprecate @polinetwork/backend@1.13.0 "contains breaking changes, use 2.0.0": callers on^1would otherwise install itv1.13.0tag and its GitHub release