Repository navigation
Conversation
Backend Phase 6 (PoliNetworkOrg/backend#93) drops the legacy grants table. Every grant now has an IdP grantor, and `key`, `source` and `grantedBy` are deprecated constants. The grants page and the user profile now: - key rows by `id` - show the grantor's IdP subject only - drop the Source column and the Telegram grantor lookup
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe grants route now loads ongoing and scheduled grants without resolving legacy grantor users. The grants page displays the IdP subject or ChangesTelegram grant loading and display
Priority: ⬇️ Low Change: Refactor Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main changes: grants use IDs, and grantor display uses the IdP subject only. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
toto04
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PoliNetworkOrg/backend#93 (RFC v3 Phase 6), which drops the legacy grants table. After that PR every grant is made by an IdP subject, and the backend still returns
key,sourceandgrantedByonly as deprecated constants, so that this dashboard keeps working. This PR stops reading them, so the backend can remove them later.grant.id;grantedBySub;getTelegramGrantsWithGrantors→getTelegramGrants: the batched Telegram lookup of legacy grantors is gone, so the page makes one fewer backend request.id.Merge order: after PoliNetworkOrg/backend#93 is deployed
Until then production still has legacy grants. Their ids can collide with IdP grant ids (that is what
keywas for), and they would show no grantor.Verification
pnpm typecheck: OK.pnpm check: 0 errors; the 35 warnings are not in the files I touched.pnpm test: 166 passed, 3 skipped.Not checked in a browser.