Skip to content

Refactor and Type Hint build.py - #1705

Merged
Naramsim merged 4 commits into
PokeAPI:masterfrom
FallenDeity:refactor-build
Nov 2, 2026
Merged

Naramsim merged 4 commits into
PokeAPI:masterfrom
FallenDeity:refactor-build

Conversation

@FallenDeity

@FallenDeity FallenDeity commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Change description

Part of #1391

  • Add type hints to build.py, along with a bit of a refactor move the helpers and constants to utils
  • Dropped some redundant queries and increased batch limit
  • Made ruff and ty checks mandatory now since we have coverage for type hints everywhere except tests (which is ignored in the config tomls)
  • updated runners to arm64 runners for performance/efficiency (noticed some decent performance improvements)

build itself is about 20%ish faster now overall gains should be about 30% with everything

AI coding assistance disclosure

For review and audit

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Naramsim

Naramsim commented Nov 2, 2026

Copy link
Copy Markdown
Member

It seems that the k8s' gql job has some problems on arm: https://github.com/PokeAPI/pokeapi/actions/runs/41400067954/job/125129779205?pr=1707 here it passes. I'll merge the PR

I'll merge-commit the PR I created so your commits will be visible in the history

@Naramsim
Naramsim merged commit f841170 into PokeAPI:master Nov 2, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants