feat: Mark get api metadata as get method#1609
Conversation
5d10d19 to
6845975
Compare
|
Thanks a lot! |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
|
Hi, after your changes the endpoint seems not to be present anymore: |
|
thats weird I'll give it a look once I am back home, looks like it got removed from the api-data update |
|
I can confirm the behavior on my local machine. I should have tested on my PC before merging. Can you test locally on your PC as well? |
I think i have an inlking why, are you able to access api/v2/meta the url should be present but only exluded from the root view? I think the reason is that meta was removed from api/v2 consolidated router in url patterns and added as a separate standalone path to url patterns hence its no longer present under root router api/v2 which is what ditto seems to crawl to clone edit: looks like the router needs to be subclassed to allow meta into the view since apiview cannot be registered into the router https://stackoverflow.com/questions/17496249/in-django-restframework-how-to-change-the-api-root-documentation |
Change description
Previously api metadata openapi schema defined it as a list which is misleading, redefined the schema to return an object since thats whats actually returned by the api (list -> get)
responses: '200': content: application/json: schema: - type: array + type: objectAI coding assistance disclosure
None
Contributor check list