Conversation
|
It looks like macos has a build failure when installing openni saying the checksum patch is different. This is unrelated to this PR. |
|
Installing openni via brew has been unsuccessful for some time, but apparently the pipeline did not fail because after that, the cloning of the googletest source code was successful which made the whole pipeline step successful. Now that the failing |
| add_library(pcl_gtest STATIC ${GTEST_SRC_DIR}/src/gtest-all.cc) | ||
| target_include_directories(pcl_gtest PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include) | ||
| add_library(pcl_gtest INTERFACE) | ||
| target_link_libraries(pcl_gtest INTERFACE GTest::gtest) |
There was a problem hiding this comment.
PCL currently still supports CMake versions < 3.20, so you would have to check the version here and use GTest::GTest instead if below 3.20 (GTest::gtest was added in 3.20)
This switches to use the standard FindGTest.cmake.
Tested on Ubuntu 24.04 (with GTest 1.14.0) and Ubuntu 26.04 (with GTest 1.17.0).