fix: the gif was cut before the grasp finished - #10
Merged
Merged
Conversation
It was sliced at frame 101, from dividing 304 frames by three episodes. The episodes are not equal: differencing consecutive frames puts the resets at 108 and 218, so the first episode is 109 frames and the old cut dropped the eight in which the arm closes on the object - the only part worth showing. Now frames 0 to 108, every third for real-time playback, with the last frame held for four so the result is visible before it loops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gif merged in #9 stops before the arm closes on the object. This replaces it with a complete episode.
What went wrong
I cut the first episode at frame 101, from dividing 304 frames by three episodes. The episodes are not equal lengths. Differencing consecutive frames puts the two resets at 108 and 218 - those two are about 12, every other frame-to-frame change is around 5 - so the first episode is 109 frames and the old cut dropped the last eight, which are exactly the ones where the grasp completes.
What replaces it
Frames 0 to 108, every third, which is real-time playback at the 20 fps the capture ran at, with the final frame held for four so the result is visible before the loop restarts. 41 frames, 1.02 MB.
The
<video>on the home page is unaffected: it playslibero-base.mp4, the full three-episode rollout, which was never truncated.