Skip to content

feat(manifest): per_file_config_keys, the config members chosen for one file (1.2.0) - #248

Closed
facontidavide wants to merge 1 commit into
mainfrom
feat/manifest-per-file-config-keys
Closed

facontidavide wants to merge 1 commit into
mainfrom
feat/manifest-per-file-config-keys

Conversation

@facontidavide

Copy link
Copy Markdown
Contributor

Why

A loader's dialog is pre-filled with the config saved for the last file it opened. Some members of that config (a CSV's chosen time column, a LeRobot episode selection) only make sense for that one file: carried over to another file they pre-select a wrong column or silently pick the wrong rows (found by the PlotJuggler 4.2.0 QA pass). Only the plugin knows which members those are.

Change (additive, 1.2.0)

  • New optional manifest field per_file_config_keys: an array of JSON Pointers into the plugin's saved config naming the members chosen for one file. The host drops them when it pre-fills the dialog for a different file, and keeps them for the same file and for a layout replay.
  • PluginDescriptor::per_file_config_keys, parsed and validated by decodeManifest (each entry must be a JSON Pointer).
  • No C-ABI change. Older parsers ignore the unknown key, so a plugin that declares it still loads on SDK 1.1.0 hosts and keeps building against 1.1.0.
  • Docs: data-source guide (config rules), manifest table, data_source_protocol.h, plugin SKILL.md, CHANGELOG.

Host side: PlotJuggler fix/loader-per-file-config-keys; plugins: pj-official-plugins fix/loader-per-file-config-keys.

🤖 Generated with Claude Code

…ne file (1.2.0)

A host pre-fills a file loader's dialog with the config its dialog saved last, with only
"filepath" pointed at the new file. Members chosen for that one file (a time column picked by
index from its header, a timestamp mode forced for its data) then apply silently to the next
file: the wrong column becomes the time axis, or samples reorder.

A data source now lists those members in its manifest as JSON Pointers:
"per_file_config_keys": ["/time_column_index"]. decodeManifest validates them (an array of
strings, each a pointer to a member) into PluginDescriptor::per_file_config_keys, empty when
absent. A host drops them when the saved config names another file and keeps them when the same
file is reopened. Declarative, like badge: no ABI or capability change, and a host built before
1.2.0 ignores the key, so a plugin declares it without raising min_sdk_required.

The data-source guide states the pre-fill rule next to the other config rules and adds the
manifest table row; VERSION and the changelog say 1.2.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ME1hnPiFTsKdcGM3RDixoG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant