Skip to content

Replace allowOres boolean with tag - #3620

Open
realugi wants to merge 4 commits into
PixelGuys:masterfrom
realugi:fix/3528
Open

realugi wants to merge 4 commits into
PixelGuys:masterfrom
realugi:fix/3528

Conversation

@realugi

@realugi realugi commented Sep 19, 2026

Copy link
Copy Markdown

fix #3528

ZON changes:

  • all ores get .targetTags = .{.allowOres}
  • for all blocks with .allowOres = true, removed .allowOres = true and added .allowOres to .tag array

Code changes:

  • removed .allowOres boolean parsing
  • removed allowOres check for the block when deciding whether an ore is eligible to be attached to a block.
  • made .targetTags for ores be an array and be mandatory. otherwise logs error and skips registration for that ore.
  • fixed a bug, where the target tags loaded from zon are allocated through the stackAllocator, which got freed immediately. Now the tag allocation uses the worldArena allocator.

Also I am very unsure about the .allowOres tag name. I considered .oreBearer, .oreBearable and .oreable. Maybe those are better?

@realugi realugi changed the title Remove allowOres and replace with a tag Replace allowOres boolean with tag Sep 19, 2026
@Wunka Wunka added the Addon Migration Guide Things that should be noted in the Addon migration section of the changelog label Sep 19, 2026
@Wunka Wunka moved this to Easy to Review in PRs to review Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Addon Migration Guide Things that should be noted in the Addon migration section of the changelog

Projects

Status: Easy to Review

Development

Successfully merging this pull request may close these issues.

Remove allowOres property from blocks and replace it with a tag

2 participants