Conversation
IntegratedQuantum
requested changes
Sep 19, 2026
IntegratedQuantum
left a comment
Member
There was a problem hiding this comment.
Is there a reason to support c_int here? Will it even be needed once we get rid of OpenGL after #102?
Author
|
So the reason to support The same applies to Vulkan (in some cases):
So if we want
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3594
I chose to use
u31instead ofu32, becauseu31is implicitly convertable toi32and thereforec_int. Also saw precedence inmain.graphics.Image.Also removed the now unneeded cast at
L1390, because bothbitmap.widthandtextureOffsetare now unsigned integers.