build: drop the License :: classifier now that license is a PEP 639 expression - #17
Merged
Merged
Conversation
…xpression pyproject.toml carries both `license = "MIT"` (PEP 639 expression) and the legacy `"License :: OSI Approved :: MIT License"` classifier. PEP 639 does not permit both together, and setuptools>=78 raises InvalidConfigError when they coexist -- the same defect already fixed on the sibling packages (pisama-core, pisama-detectors, pisama-agent-sdk, pisama-verifier-gym) in this same review round. hatchling tolerates it today, which is why the build did not fail, but it is latent breakage behind a future setuptools bump. Verified: ruff, mypy, pytest (196 passed, 70.51% cov) all pass; `python -m build` + `twine check` PASS on both artifacts; wheel METADATA confirmed `License-Expression: MIT` present and no `Classifier: License ::` line. Patch bump to 0.6.2 because the fix only matters once it reaches PyPI. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlcarried both a PEP 639license = "MIT"expression and thelegacy
"License :: OSI Approved :: MIT License"classifier. PEP 639 doesnot permit both together, and
setuptools>=78raisesInvalidConfigErrorwhen they coexist.
hatchling(this repo's build backend) tolerates ittoday, which is why builds have not failed yet, but it's latent breakage
behind a future
setuptoolsbump -- and inconsistent with the siblingpackages (pisama-core, pisama-detectors, pisama-agent-sdk,
pisama-verifier-gym) already fixed for the same defect.
License ::classifier line;license = "MIT"is untouched.__version__fallback).[0.6.2].Test plan
ruff check src tests-- passmypy src/pisama-- pass, 65 filespytest -q --cov=pisama --cov-fail-under=60-- 196 passed, 70.51% coveragepython -m build && python -m twine check dist/*-- PASS on both sdist and wheelMETADATA:License-Expression: MITpresent,License-File: LICENSEpresent, noClassifier: License ::line🤖 Generated with Claude Code