Remove L2G example workflow and model#795
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRemoves the L2G ONNX model and auto-grasp objective, excludes the model directory from installation, and enables the objective in integration-test parameter generation. ChangesL2G objective and model removal
Possibly related issues
Possibly related PRs
Comment |
|
griswaldbrooks
approved these changes
Jul 20, 2026
griswaldbrooks
marked this pull request as ready for review
July 20, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Motivation
The
ML Auto Grasp Object from Clicked PointObjective is the final current-main consumer of L2G. Its redistributed ONNX weight derives from an upstream checkpoint with no license grant, and there is no replacement for point-cloud-to-grasp generation.This PR follows the current-documentation retirement in PickNikRobotics/moveit_pro#20655 and must land before the core L2G Behavior is removed.
Changes
ML Auto Grasp Object from Clicked Pointfromlab_sim.lab_sim/models/l2g.onnx.modelsdirectory.Shared grasp visualization assets and reusable non-L2G subtrees remain because other Objectives still use them.
Compatibility
This targets
mainfor MoveIt Pro 10.0 only. The 9.4.1 tag is unchanged. The exact historical LFS object (fc1fd4a7…e0965b5) was fetched from origin and verified at 15,618,125 bytes.Validation
GetGraspPoseFromPointCloud, Objective-name, or model-path references.git diff --check: passed.Merge order
Closes PickNikRobotics/moveit_pro#20652