ci: run push workflows on main - #34
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour. 📝 SummarySummary by CodeRabbit
WalkthroughSix GitHub Actions workflows now run on pushes to ChangesWorkflow push triggers
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to This change directs the six workflows to run on pushes to main while leaving pull-request triggers unchanged. No concrete merge risk remains. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (3 passed)
Full details: Human Review CheckExplanation The PR changes six GitHub Actions workflows, so it is a CI/CD change. Each workflow changes its push trigger from
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
dv-picknik
enabled auto-merge
September 28, 2026 15:16
The push triggers name master, which here mirrors upstream, while PRs merge to main, the default branch. No workflow runs on merge to main, so the pixi Windows crash introduced by #30 never showed there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dv-picknik
force-pushed
the
ci/push-workflows-on-main
branch
from
September 28, 2026 15:17
77f1b1a to
ba2fa03
Compare
scopenhagenPickNik
approved these changes
Sep 28, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
dv-picknik
added a commit
that referenced
this pull request
Sep 28, 2026
Reapplies 7b39030 (#28) onto 4.9.0, whose CI files differ enough that the hunks do not cherry-pick, and folds in ba2fa03 (#34). conan install gains -o "zeromq/*:encryption=tweetnacl". libsodium is the only package in the graph built by msbuild, and its hand-written .vcxproj takes PlatformToolset v145 from compiler.version=195 while vcvars lands on VCToolsVersion 14.44, which msbuild rejects (MSB8052). The copy of tweetnacl bundled in libzmq drops the dependency. CURVE support is unchanged. pixi needs the "Visual Studio 18 2026" generator named explicitly, which exists only in cmake >= 4.2, so the floor moves and the lock is regenerated at cmake 4.4.3. That makes pixi.lock format v7, which v0.40.3 cannot read, so setup-pixi and pixi move up with it. ros2-rolling pins OS_CODE_NAME to noble: rolling now targets Ubuntu 26.04 (resolute), and packages.ros.org publishes no rolling debs for it yet. Verified 2026-09-28, the resolute dist carries 0 ros-rolling-* packages against 2150 on noble. fail-fast is off on both matrices. On pixi a failing windows job was cancelling ubuntu mid-build; on cmake_windows a failing Debug job was cancelling Release before it could report. Push triggers move from master to main, which is #34's change. It covers one workflow #34 could not, cmake_ubuntu_sanitizers.yml, which exists only on the 4.9.0 line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 28, 2026
Records main as merged without taking its tree. This branch is not a delta on main: it is upstream tag 4.9.0 with each of the fork's divergent commits re-evaluated and reapplied, so main's 4.7.2-based tree is the wrong side of every file. That replay was agreed before the branch was built. Everything main carries is accounted for in the commits below: 663cfa3..b8d70d6 the fork's own 22 commits, evaluated one by one when this branch was built: 13 carried, 9 dropped as already upstream in 4.9.0 or net no-op 7b39030 (#28) reapplied in the ci commit, together with ba2fa03 (#34) 13c9fe2 (#30) reapplied as the ReactiveSequence commit eac4a51 (#33) folded into that same commit, so the test never lands in the form that crashes the pixi Windows job c4b23ea, b61a398 c4b23ea is itself a backport of this branch's empty subtree default fix; b61a398's follow-up is folded into it here Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 28, 2026
Reapplies 7b39030 (#28) onto 4.9.0, whose CI files differ enough that the hunks do not cherry-pick, and folds in ba2fa03 (#34). conan install gains -o "zeromq/*:encryption=tweetnacl". libsodium is the only package in the graph built by msbuild, and its hand-written .vcxproj takes PlatformToolset v145 from compiler.version=195 while vcvars lands on VCToolsVersion 14.44, which msbuild rejects (MSB8052). The copy of tweetnacl bundled in libzmq drops the dependency. CURVE support is unchanged. pixi needs the "Visual Studio 18 2026" generator named explicitly, which exists only in cmake >= 4.2, so the floor moves and the lock is regenerated at cmake 4.4.3. That makes pixi.lock format v7, which v0.40.3 cannot read, so setup-pixi and pixi move up with it. ros2-rolling pins OS_CODE_NAME to noble: rolling now targets Ubuntu 26.04 (resolute), and packages.ros.org publishes no rolling debs for it yet. Verified 2026-09-28, the resolute dist carries 0 ros-rolling-* packages against 2150 on noble. fail-fast is off on both matrices. On pixi a failing windows job was cancelling ubuntu mid-build; on cmake_windows a failing Debug job was cancelling Release before it could report. Push triggers move from master to main, which is #34's change. It covers one workflow #34 could not, cmake_ubuntu_sanitizers.yml, which exists only on the 4.9.0 line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 28, 2026
Records main as merged without taking its tree. This branch is not a delta on main: it is upstream tag 4.9.0 with each of the fork's divergent commits re-evaluated and reapplied, so main's 4.7.2-based tree is the wrong side of every file. That replay was agreed before the branch was built. Everything main carries is accounted for in the commits below: 663cfa3..b8d70d6 the fork's own 22 commits, evaluated one by one when this branch was built: 13 carried, 9 dropped as already upstream in 4.9.0 or net no-op 7b39030 (#28) reapplied in the ci commit, together with ba2fa03 (#34) 13c9fe2 (#30) reapplied as the ReactiveSequence commit eac4a51 (#33) folded into that same commit, so the test never lands in the form that crashes the pixi Windows job c4b23ea, b61a398 c4b23ea is itself a backport of this branch's empty subtree default fix; b61a398's follow-up is folded into it here Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 29, 2026
Reapplies 7b39030 (#28) onto 4.9.0, whose CI files differ enough that the hunks do not cherry-pick, and folds in ba2fa03 (#34). conan install gains -o "zeromq/*:encryption=tweetnacl". libsodium is the only package in the graph built by msbuild, and its hand-written .vcxproj takes PlatformToolset v145 from compiler.version=195 while vcvars lands on VCToolsVersion 14.44, which msbuild rejects (MSB8052). The copy of tweetnacl bundled in libzmq drops the dependency. CURVE support is unchanged. pixi needs the "Visual Studio 18 2026" generator named explicitly, which exists only in cmake >= 4.2, so the floor moves and the lock is regenerated at cmake 4.4.3. That makes pixi.lock format v7, which v0.40.3 cannot read, so setup-pixi and pixi move up with it. ros2-rolling pins OS_CODE_NAME to noble: rolling now targets Ubuntu 26.04 (resolute), and packages.ros.org publishes no rolling debs for it yet. Verified 2026-09-28, the resolute dist carries 0 ros-rolling-* packages against 2150 on noble. fail-fast is off on both matrices. On pixi a failing windows job was cancelling ubuntu mid-build; on cmake_windows a failing Debug job was cancelling Release before it could report. Push triggers move from master to main, which is #34's change. It covers one workflow #34 could not, cmake_ubuntu_sanitizers.yml, which exists only on the 4.9.0 line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 29, 2026
Records main as merged without taking its tree. This branch is not a delta on main: it is upstream tag 4.9.0 with each of the fork's divergent commits re-evaluated and reapplied, so main's 4.7.2-based tree is the wrong side of every file. That replay was agreed before the branch was built. Everything main carries is accounted for in the commits below: 663cfa3..b8d70d6 the fork's own 22 commits, evaluated one by one when this branch was built: 13 carried, 9 dropped as already upstream in 4.9.0 or net no-op 7b39030 (#28) reapplied in the ci commit, together with ba2fa03 (#34) 13c9fe2 (#30) reapplied as the ReactiveSequence commit eac4a51 (#33) folded into that same commit, so the test never lands in the form that crashes the pixi Windows job c4b23ea, b61a398 c4b23ea is itself a backport of this branch's empty subtree default fix; b61a398's follow-up is folded into it here Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 29, 2026
Reapplies 7b39030 (#28) onto 4.9.0, whose CI files differ enough that the hunks do not cherry-pick, and folds in ba2fa03 (#34). conan install gains -o "zeromq/*:encryption=tweetnacl". libsodium is the only package in the graph built by msbuild, and its hand-written .vcxproj takes PlatformToolset v145 from compiler.version=195 while vcvars lands on VCToolsVersion 14.44, which msbuild rejects (MSB8052). The copy of tweetnacl bundled in libzmq drops the dependency. CURVE support is unchanged. pixi needs the "Visual Studio 18 2026" generator named explicitly, which exists only in cmake >= 4.2, so the floor moves and the lock is regenerated at cmake 4.4.3. That makes pixi.lock format v7, which v0.40.3 cannot read, so setup-pixi and pixi move up with it. ros2-rolling pins OS_CODE_NAME to noble: rolling now targets Ubuntu 26.04 (resolute), and packages.ros.org publishes no rolling debs for it yet. Verified 2026-09-28, the resolute dist carries 0 ros-rolling-* packages against 2150 on noble. fail-fast is off on both matrices. On pixi a failing windows job was cancelling ubuntu mid-build; on cmake_windows a failing Debug job was cancelling Release before it could report. Push triggers move from master to main, which is #34's change. It covers one workflow #34 could not, cmake_ubuntu_sanitizers.yml, which exists only on the 4.9.0 line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 29, 2026
Records main as merged without taking its tree. This branch is not a delta on main: it is upstream tag 4.9.0 with each of the fork's divergent commits re-evaluated and reapplied, so main's 4.7.2-based tree is the wrong side of every file. That replay was agreed before the branch was built. Everything main carries is accounted for in the commits below: 663cfa3..b8d70d6 the fork's own 22 commits, evaluated one by one when this branch was built: 13 carried, 9 dropped as already upstream in 4.9.0 or net no-op 7b39030 (#28) reapplied in the ci commit, together with ba2fa03 (#34) 13c9fe2 (#30) reapplied as the ReactiveSequence commit eac4a51 (#33) folded into that same commit, so the test never lands in the form that crashes the pixi Windows job c4b23ea, b61a398 c4b23ea is itself a backport of this branch's empty subtree default fix; b61a398's follow-up is folded into it here Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 29, 2026
Reapplies 7b39030 (#28) onto 4.9.0, whose CI files differ enough that the hunks do not cherry-pick, and folds in ba2fa03 (#34). conan install gains -o "zeromq/*:encryption=tweetnacl". libsodium is the only package in the graph built by msbuild, and its hand-written .vcxproj takes PlatformToolset v145 from compiler.version=195 while vcvars lands on VCToolsVersion 14.44, which msbuild rejects (MSB8052). The copy of tweetnacl bundled in libzmq drops the dependency. CURVE support is unchanged. pixi needs the "Visual Studio 18 2026" generator named explicitly, which exists only in cmake >= 4.2, so the floor moves and the lock is regenerated at cmake 4.4.3. That makes pixi.lock format v7, which v0.40.3 cannot read, so setup-pixi and pixi move up with it. ros2-rolling pins OS_CODE_NAME to noble: rolling now targets Ubuntu 26.04 (resolute), and packages.ros.org publishes no rolling debs for it yet. Verified 2026-09-28, the resolute dist carries 0 ros-rolling-* packages against 2150 on noble. fail-fast is off on both matrices. On pixi a failing windows job was cancelling ubuntu mid-build; on cmake_windows a failing Debug job was cancelling Release before it could report. Push triggers move from master to main, which is #34's change. It covers one workflow #34 could not, cmake_ubuntu_sanitizers.yml, which exists only on the 4.9.0 line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dv-picknik
added a commit
that referenced
this pull request
Sep 29, 2026
Records main as merged without taking its tree. This branch is not a delta on main: it is upstream tag 4.9.0 with each of the fork's divergent commits re-evaluated and reapplied, so main's 4.7.2-based tree is the wrong side of every file. That replay was agreed before the branch was built. Everything main carries is accounted for in the commits below: 663cfa3..b8d70d6 the fork's own 22 commits, evaluated one by one when this branch was built: 13 carried, 9 dropped as already upstream in 4.9.0 or net no-op 7b39030 (#28) reapplied in the ci commit, together with ba2fa03 (#34) 13c9fe2 (#30) reapplied as the ReactiveSequence commit eac4a51 (#33) folded into that same commit, so the test never lands in the form that crashes the pixi Windows job c4b23ea, b61a398 c4b23ea is itself a backport of this branch's empty subtree default fix; b61a398's follow-up is folded into it here Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Point the
pushtriggers of six workflows atmain. They namedmaster, which in this fork mirrors upstream, while PRs merge tomain, the default branch. So no workflow runs on merge tomain. That's how the pixi Windows crash from #30 went unnoticed there. #33 fixes the crash.doxygen-gh-pages.ymlalready listsmainand is unchanged. Note thatcmake_ubuntu.ymlwill also upload coverage to Codecov on every push tomain, and every job here runs once more per merge.pixi.yamlhas CRLF line endings, which the edit keeps.This was part of #33. CodeRabbit's Human Review Check fails any workflow change until a requested human reviewer overrides it, so this PR needs that override.
🤖 Generated with Claude Code