Refactor/optimize event paths - #132
Open
tejaede wants to merge 4 commits into
Open
Conversation
tejaede
force-pushed
the
refactor/optimize-event-paths
branch
from
July 27, 2026 19:35
bf97f4a to
02313ac
Compare
marchant
requested changes
Aug 13, 2026
| mutableEventTarget = mutableEvent.target; | ||
| eventPath = this.eventPathForTarget(mutableEventTarget); | ||
| mutableEvent._composedPath = eventPath; | ||
| // eventPath = this.eventPathForTarget(mutableEventTarget); |
| // this._previousEvent = event; | ||
| // } | ||
|
|
||
| // ... operation 1 ... |
| value: function (capture, target, eventType) { | ||
| let targetsByType = this._dispatchedTargetsByEventTypeByComposedPathMember.get(target), | ||
| dispatchedTargets = targetsByType && targetsByType.get(eventType), | ||
| dispatchedTargetsIterator = dispatchedTargets && dispatchedTargets.entries(), |
Contributor
There was a problem hiding this comment.
could use the optional chaining operator ?. here:
dispatchedTargetsIterator = dispatchedTargets?.entries(),
|
|
||
| __clearCachedPathForTargetAndEventType: { | ||
| value: function (capture, target, eventType) { | ||
| if (capture) { |
Contributor
There was a problem hiding this comment.
Bellow, if this._capturePathByTargetAndEventType has indeed target, we're accessing it 3 times:
this._capturePathByTargetAndEventType.has(target)
this._capturePathByTargetAndEventType.get(target)
this._capturePathByTargetAndEventType.get(target)
same in the else, would be great to optimize that if possible. The if could be:
if (this._capturePathByTargetAndEventType.get(target)?.has(eventType)) instead, right?
Or even with no if at all ?:
this._capturePathByTargetAndEventType.get(target)?.delete(eventType);
|
|
||
| __invokeTargetListenersForEventPhase: { | ||
| value: function __invokeTargetListenersForEventPhase(iTarget, mutableEvent, phase, _eventType) { | ||
| value: function __invokeTargetListenersForEventPhase(iTarget, mutableEvent, phase, _eventType, phaseEventPath) { |
Contributor
There was a problem hiding this comment.
We should document why phaseEventPath is now an argument
Create a cache of the path for each event target and type that only includes the targets in the path that has a listener for the type
marchant
force-pushed
the
refactor/optimize-event-paths
branch
from
August 18, 2026 05:00
4195982 to
847f9b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.