Skip to content

Add Immune.Capture, Immune.Infiltrate, Immune.EngineerRepair for AttachEffect - #2451

Open
dh381-1 wants to merge 18 commits into
Phobos-developers:developfrom
dh381-1:new/InmmueAE
Open

dh381-1 wants to merge 18 commits into
Phobos-developers:developfrom
dh381-1:new/InmmueAE

Conversation

@dh381-1

@dh381-1 dh381-1 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

  • Immune.Capture, Immune.Infiltrate and Immune.EngineerRepair only apply to buildings, respectively preventing capture, infiltration by enemy, and repair by friendly engineers while AE is active.

In rulesmd.ini:

[SOMEATTACHEFFECT]                             ; AttachEffectType
Immune.Capture=false                           ; boolean
Immune.Infiltrate=false                        ; boolean
Immune.EngineerRepair=false                    ; boolean

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/801/1

Comment thread src/New/Type/AttachEffectTypeClass.h Outdated
@Fly-Star-him

Copy link
Copy Markdown
Contributor

Perhaps we could implement a corresponding solution in Infantry's WhatAction as well.

@Fryone

Fryone commented Oct 6, 2026

Copy link
Copy Markdown
Contributor
image While, entering is not allowed, you can still put infantry on the building cell 🤔

@Fryone

Fryone commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Something is broken on the latest. While, it's forbidden to enter by command - it's still possible by using waypoint before Immune applied. So infantry still can enter while AE applied, which wasn't possible in previous build.

@dh381-1

dh381-1 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Something is broken on the latest. While, it's forbidden to enter by command - it's still possible by using waypoint before Immune applied. So infantry still can enter while AE applied, which wasn't possible in previous build.

It seems that infantry can only enter through the waypoints when a spy is infiltrating. Also, what operation were you performing when your crash was triggered? I couldn't find any situation in which it crashes.

@Coronia Coronia added ⚙️T1 T1 maintainer review is sufficient Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. labels Oct 9, 2026
Comment thread docs/Whats-New.md Outdated
@DeathFishAtEase

DeathFishAtEase commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

If someone is going to test, please confirm whether this PR has a similar issue.


Tested by: https://www.phoboscn.top/t/topic/801/6?u=noble_fish

image

dh381-1 and others added 3 commits October 9, 2026 16:04
Because local changes were made first and then a pull was performed, bfb02e5 did not include the correction from 83ebddc, and because the remote was merged during the pull, the original error was reintroduced, resulting in two Changelog entries
@DeathFishAtEase DeathFishAtEase added On Hold Due to some reasons, it cannot be completed temporarily and removed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. labels Oct 9, 2026
@DeathFishAtEase

DeathFishAtEase commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

I see you have also disabled Multi Engineer's rush before it can actually Capture (although I don't think this design is appropriate, let's leave it as it is for now), but if Engineers are already rushing, adding an AE with Immune.Capture=true at this point cannot prevent it from being rushed.

228119_G

Maybe you can take a look at 0x519EA5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs improvement Needs testing On Hold Due to some reasons, it cannot be completed temporarily ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants