test: cover EncounterTransformer non-DataFrame validation branches - #192
Closed
haas26p-ctrl wants to merge 1 commit into
Closed
Conversation
Add tests for TypeError on list encounter_df and for array X passing through _validate_X via public fit. Closes PhilanthroPy-Project#152.
Author
|
Closing this PR — withdrawing the contribution. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only coverage for two unexecuted validation branches in
EncounterTransformer:test_encounter_transformer_rejects_non_dataframe_encounter_df— list-of-dictsencounter_dfraisesTypeErrormatchingmust be a pd.DataFrametest_encounter_transformer_validate_x_passes_arrays_through—assert t.fit(np.zeros((2, 3))) is t(arrayXuses the publicfitpath;_validate_Xearly-return)No source changes under
philanthropy/. CHANGELOG + CONTRIBUTORS updated.Closes #152.
Test plan
python -m pytest tests/test_preprocessing.py tests/test_as_of_cutoff.py --cov=philanthropy.preprocessing._encounters --cov-report=term-missing -qmake ci/make riskcov