fix(gates): register #7612's gap test in the gc-repsel corpus - #7619
Merged
Conversation
added 2 commits
August 8, 2026 05:00
check_test_registration.py has been red on main since #7612 merged: its gap test was a DARK TEST -- in test-files/ but in no registry, so gc-stress and gc-moving-witnesses never ran it. Registered; verified stable under PERRY_GC_ZEAL=1 PERRY_GC_PROTECT_FROMSPACE=1 before registering, since registration changes what those gates execute. Second time a merge of mine turned lint red via a script my checklist did not include (first: addr_class via #7579/#7585). The checklist is replaced by running the whole lint job's script set.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe project version was updated from ChangesRelease metadata and GC corpus
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_test_registration.py— part oflint— has been red onmainsince #7612 merged:test_gap_repsel_element_shape_loop_clone.tswas a DARK TEST, present intest-files/but registered in no suite, sogc-stressandgc-moving-witnessesnever ran it. That gate exists precisely so a GC-relevant test cannot silently not-run; it did its job, and my merge checklist did not include it.Registered in
test-parity/gc_repsel_corpus.txt(bare-name format). Before registering — since registration changes what those gates execute — verified the test is stable underPERRY_GC_ZEAL=1 PERRY_GC_PROTECT_FROMSPACE=1(hash-identical output to the plain run). The #7612 clone stands down by construction under moving-loop polls, so the stress arms exercise the slow path, which is the intended coverage.This is the second lint breakage from a merge of mine via a script outside my four-item checklist (first: addr-class via #7579, fixed in #7585). The lint job runs a dozen-plus scripts; the durable fix on my side is running the job's full script set at merge time rather than a memorized subset — recorded in my process notes.
check_test_registration.pynow exits 0; no code touched.Summary by CodeRabbit
Chores
Tests