Skip to content

fix(gates): register #7612's gap test in the gc-repsel corpus - #7619

Merged
proggeramlug merged 2 commits into
mainfrom
fix/lint-register-7612-test
Aug 8, 2026
Merged

fix(gates): register #7612's gap test in the gc-repsel corpus#7619
proggeramlug merged 2 commits into
mainfrom
fix/lint-register-7612-test

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

check_test_registration.py — part of lint — has been red on main since #7612 merged: test_gap_repsel_element_shape_loop_clone.ts was a DARK TEST, present in test-files/ but registered in no suite, so gc-stress and gc-moving-witnesses never ran it. That gate exists precisely so a GC-relevant test cannot silently not-run; it did its job, and my merge checklist did not include it.

Registered in test-parity/gc_repsel_corpus.txt (bare-name format). Before registering — since registration changes what those gates execute — verified the test is stable under PERRY_GC_ZEAL=1 PERRY_GC_PROTECT_FROMSPACE=1 (hash-identical output to the plain run). The #7612 clone stands down by construction under moving-loop polls, so the stress arms exercise the slow path, which is the intended coverage.

This is the second lint breakage from a merge of mine via a script outside my four-item checklist (first: addr-class via #7579, fixed in #7585). The lint job runs a dozen-plus scripts; the durable fix on my side is running the job's full script set at merge time rather than a memorized subset — recorded in my process notes.

check_test_registration.py now exits 0; no code touched.

Summary by CodeRabbit

  • Chores

    • Updated the application version to 0.5.1353.
  • Tests

    • Expanded automated validation coverage for garbage-collection representation selection, improving confidence in related runtime behavior.

Ralph Küpper added 2 commits August 8, 2026 05:00
check_test_registration.py has been red on main since #7612 merged: its gap
test was a DARK TEST -- in test-files/ but in no registry, so gc-stress and
gc-moving-witnesses never ran it. Registered; verified stable under
PERRY_GC_ZEAL=1 PERRY_GC_PROTECT_FROMSPACE=1 before registering, since
registration changes what those gates execute.

Second time a merge of mine turned lint red via a script my checklist did not
include (first: addr_class via #7579/#7585). The checklist is replaced by
running the whole lint job's script set.
@proggeramlug
proggeramlug merged commit f016897 into main Aug 8, 2026
28 of 45 checks passed
@proggeramlug
proggeramlug deleted the fix/lint-register-7612-test branch August 8, 2026 03:01
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5eca9ea0-6c82-43b4-b4af-e7a3431e29f8

📥 Commits

Reviewing files that changed from the base of the PR and between 55ddab0 and 7b6f201.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • CLAUDE.md
  • Cargo.toml
  • test-parity/gc_repsel_corpus.txt

📝 Walkthrough

Walkthrough

The project version was updated from 0.5.1352 to 0.5.1353. The GC representation-selection corpus now registers test_gap_repsel_element_shape_loop_clone.

Changes

Release metadata and GC corpus

Layer / File(s) Summary
Version metadata
CLAUDE.md, Cargo.toml
The documented and workspace package versions were updated to 0.5.1353.
GC corpus registration
test-parity/gc_repsel_corpus.txt
The corpus now includes test_gap_repsel_element_shape_loop_clone.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested labels: bug

Suggested reviewers: jdalton

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lint-register-7612-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant