Mark the Create Archive checklist item as done - #1128
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
==========================================
+ Coverage 52.30% 52.33% +0.03%
==========================================
Files 354 354
Lines 12091 12097 +6
Branches 2185 2186 +1
==========================================
+ Hits 6324 6331 +7
+ Misses 5543 5540 -3
- Partials 224 226 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cecilia-donnelly
left a comment
There was a problem hiding this comment.
This looks good! I went through the whole checklist and it all worked beautifully. I wonder, separately, if we could set the checklist item true on the backend when the archive is created.
| }, | ||
| ], | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Okay, I think I see what's happening. Is this to reset the API response to what it would be in a base case, before editing the checklistItems in the service?
There was a problem hiding this comment.
Yes, exactly! And setting the property on BE would be the optimal solution, when the archive is created. The good part is that, up until then, this small hack will do the job and if we move the functionality on BE, it will still work seamlessly, until we decide and remove the change from FE.
The Create Archive checklist item would never get checked as done, so the user would never see the list as 100%. The Create Archive is marked as done in the FE, because a user needs to have an archive in order to land on the private workspace. Issue: PER-10681
b051beb to
eb8d761
Compare
The Create Archive checklist item would never get checked as done, so the user would never see the list as 100%. The Create Archive is marked as done in the FE, because a user needs to have an archive in order to land on the private workspace.
Issue: PER-10681
Steps to test
EXPECTED: The "Create Archive" item on the checklist is checked and the progress bar is at 14%.
EXPECTED: The steps on the checklist get checked correctly and the progress bar updates accordingly.