Skip to content

Mark the Create Archive checklist item as done - #1128

Open
aasandei-vsp wants to merge 1 commit into
mainfrom
PER-10681-hardcode-create
Open

Mark the Create Archive checklist item as done#1128
aasandei-vsp wants to merge 1 commit into
mainfrom
PER-10681-hardcode-create

Conversation

@aasandei-vsp

Copy link
Copy Markdown
Contributor

The Create Archive checklist item would never get checked as done, so the user would never see the list as 100%. The Create Archive is marked as done in the FE, because a user needs to have an archive in order to land on the private workspace.

Issue: PER-10681

Steps to test

  1. Create an account
  2. Follow the onboarding flow and land on the private workspace
    EXPECTED: The "Create Archive" item on the checklist is checked and the progress bar is at 14%.
  3. Upload a file, publish de archive etc.
    EXPECTED: The steps on the checklist get checked correctly and the progress bar updates accordingly.

@aasandei-vsp aasandei-vsp self-assigned this Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.33%. Comparing base (cccb683) to head (eb8d761).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
+ Coverage   52.30%   52.33%   +0.03%     
==========================================
  Files         354      354              
  Lines       12091    12097       +6     
  Branches     2185     2186       +1     
==========================================
+ Hits         6324     6331       +7     
+ Misses       5543     5540       -3     
- Partials      224      226       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cecilia-donnelly cecilia-donnelly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I went through the whole checklist and it all worked beautifully. I wonder, separately, if we could set the checklist item true on the backend when the archive is created.

},
],
});
});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think I see what's happening. Is this to reset the API response to what it would be in a base case, before editing the checklistItems in the service?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly! And setting the property on BE would be the optimal solution, when the archive is created. The good part is that, up until then, this small hack will do the job and if we move the functionality on BE, it will still work seamlessly, until we decide and remove the change from FE.

@aasandei-vsp aasandei-vsp added the QA This issue is ready for QA / user acceptance testing label Aug 10, 2026
The Create Archive checklist item would never get checked
as done, so the user would never see the list as 100%.
The Create Archive is marked as done in the FE, because a user
needs to have an archive in order to land on the private workspace.

Issue: PER-10681
@aasandei-vsp
aasandei-vsp force-pushed the PER-10681-hardcode-create branch from b051beb to eb8d761 Compare August 10, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA This issue is ready for QA / user acceptance testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants