Repository navigation
fix y pr frenan con un flag que no conocen: fix --dry-run escribía en el código — 0.8.5 - #39
Merged
Merged
Conversation
… el código — 0.8.5
# Conflicts: # CHANGELOG.md # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parche fix . --dry-runescribía en el código sin avisar.--dry-runes depr, peroparseArgsacepta cualquier flag en cualquier comando, así quefixlo ignoraba y aplicaba los arreglos. Lo encontramos porque nos pasó a nosotros al probar el #38.Qué cambió
fixypr, los dos comandos que cambian algo, frenan con un flag que no conocen, antes de tocar nada:parche fix . --dry-runparche scan, oparche pr --dry-runparche fix . --pakc <id>parche pr . --dryrunEl resto de los comandos lee los flags como antes. La Action solo le pasa a
pr--pack,--verifyy--dry-run, que están en la lista, y hay un test que lo controla.Para probarlo
Sale con error y
git statusqueda limpio.npm testen verde.Queda pendiente
Cuando se mergee el #32,
ai-upgradetambién va a cambiar cosas: hay que sumarlo aWRITE_FLAGS.Orden de merge
Es la 0.8.5 y va después de la 0.8.4 (#38). Solo choca en
package.json, el lockfile y el CHANGELOG.