Repository navigation
Dependabot no propone mayores de @babel/parser - #37
Merged
Merged
Conversation
…cript válido y no suma detección
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot deja de proponer mayores de
@babel/parser, igual que con TypeScript. Solo cambia.github/dependabot.yml: no se publica nada.Por qué no conviene el #33 (Babel 8)
Los tests pasan y no se rompe nada de lo que corre Parche, pero no da nada y cuesta:
parseCheckfalla>=6^22.18.0 || >=24.11.0; Parche promete>=22La regresión. Babel 8 rechaza TypeScript válido:
declare global { var prisma: PrismaClient | undefined }seguido deconst prisma = …, el singleton típico de Next con Prisma. DaIdentifier 'prisma' has already been declared. Babel 7 lo acepta. Apareció en 1 de las 178 carpetas. Si Parche modifica un archivo así, la verificación falla y no hay PR.Por qué crece la instalación.
jscodeshift17.4.0, la última, sigue en^7.24.7y trae su propio Babel 7, así que quedan las dos versiones.Cuándo volver a mirarlo
Cuando
jscodeshiftpase a Babel 8. El ignore se saca con este mismo archivo.Para probarlo
Reproduce la regresión con Babel 8 instalado:
node --input-type=module -e "import { parse } from '@babel/parser'; parse('declare global { var prisma: any }\nconst prisma = 1;', { sourceType: 'module', plugins: ['typescript'] })"Al mergear, el #33 se cierra a mano.